Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a unit test to demonstrate and detect issue #116 #143

Closed
wants to merge 1 commit into from

Conversation

rwdalpe
Copy link

@rwdalpe rwdalpe commented Jun 23, 2015

Create a parent-child model where the child has a FK reference to
the parent. Have the parent have an IList collection of children.

EF will automatically put a HashSet in for ICollection, so it must
be IList to demonstrate the issue.

The test then uses OwnedCollection to demonstrate multiple adding
of children to the parent element. The test will fail accordingly when it expects to get 2 children but instead gets 4.

Referencing issue #116

Create a parent-child model where the child has a FK reference to
the parent. Have the parent have an IList collection of children.

EF will automatically put a HashSet in for ICollection, so it must
be IList to demonstrate the issue.

The test then uses OwnedCollection to demonstrate multiple adding
of children to the parent element.
@ghost ghost added the bug label Jul 22, 2015
@JonathanMagnan
Copy link
Member

Hello @rwdalpe ,

Thank you for the pull, we have merged it manually (had some conflict with the project structure change) which successfully reproduced the issue.

We will look now at the pull #174 , to check if it fixes it correctly.

JonathanMagnan added a commit that referenced this pull request Apr 23, 2020
merge manually pull #143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants