Tracking PR for v0.7 release #599
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial outline of the block-producer redesign. Includes a new mempool which can track transaction and batch dependencies as a graph. This enables more complex mempool strategies.
Co-authored-by: Bobbin Threadbare <[email protected]>
This makes `AuthenticatedTransaction` much cheaper to clone and move around.
) `BatchGraph` now uses `DependencyGraph<BatchJobId, TransactionBatch` internally. This allows us to focus test energy on a single graph type instead of replicating tests and edge cases with more specific implementations. This requires adjusting `DependencyGraph` to separate the `insert` method into `insert_pending` and `promote_pending` to support inserting a batch into the graph while still waiting on its proof.
Doing this now in an effort to simplify subsequent work that will be less isolated.
feat(block-producer): merge next into next-block-producer
Replace FIFO with the mempool block-producer rework. This still has known bugs and issues; notably the client's integration tests sometimes hang.
Notably also merges `next` in.
Previously only http was supported.
* refactor: remove unused dependencies, migrate code to the latest `next` of `miden-base` * chore: update `miden-base` * refactor: migrate to `assert_matches!` macro * chore: switch to the `next` branch of `miden-base` * refactor: add missed `assert_matches!`
…554) * feat: prepare DB structure for new delta format * chore: remove unused dependencies * fix: delta merging bugs * fix: remove obsolete check in test * fix: update directory name to correspond common format * refactor: rename DB tables * refactor: add `WITHOUT ROWID` to tables where ROWID is unnecessary * refactor: don't require allocations and clones for `bulk_insert` * fix: get rid of `unsafe` in `NonFungibleAsset` construction from `Word` * refactor: extract utils to separate module inside `sql` * refactor: rename `account_nonce_updates` table to `account_deltas` * docs: improve function description for `select_account_state_delta` * fix: compilation errors * refactor: rename `account_hash_update_from_row` to `account_summary_from_row` * refactor: rename `account_hash_update_from_row` to `account_summary_from_row` * refactor: get rid of `u32_to_value` * refactor: remove unnecessary indexes * refactor: multiple inserts instead of `bulk_insert` * refactor: multiple queries instead of single query with unions * refactor: implement `insert_sql` macro * docs: improve doc comment for `insert_sql` macro
Merge in the `next-block-producer` feature branch. This replaces the FIFO queue with a mempool based on a transaction dependency graph.
This was previously added in #544 but was mistakenly dropped by a rebase.
Instruments all functions and consolidates errors into a single enum.
Also updates `tracing` so we can use `target = const` in `#[instrument]`
* feat: Enable storage map querying * reviews: Clarify doc comments; error messages; iterate over requests instead of retreived accounts; README suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tracking PR for v0.7 release.