Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid post__not_in #3

Closed
nicholasio opened this issue Dec 11, 2017 · 1 comment · Fixed by #38
Closed

Avoid post__not_in #3

nicholasio opened this issue Dec 11, 2017 · 1 comment · Fixed by #38
Assignees
@dinhtungdu
Labels
help wanted type:enhancement New feature or request.
Milestone
2.3.3

Comments

@nicholasio
Copy link
Member

The plugin currently uses post__not_in https://github.com/10up/simple-page-ordering/blob/develop/simple-page-ordering.php#L169.

Ideally we shouldn't be using it, but haven't dig into it to see if its feasible to rewrite that method without post__not_in.

https://10up.github.io/Engineering-Best-Practices/php/#performance

Also had this called out by VIP recently.
@ryanwelcher ryanwelcher added the type:enhancement New feature or request. label Mar 2, 2018
@jeffpaul jeffpaul added this to the 2.4.0 milestone Oct 8, 2019
@jeffpaul
Copy link
Member

jeffpaul commented Oct 8, 2019

@nicholasio thanks for calling that out, is it something you'd be able to work up a PR to resolve?

@dinhtungdu dinhtungdu mentioned this issue Feb 17, 2020
Closed
6 tasks
@dinhtungdu dinhtungdu self-assigned this Feb 17, 2020
@dinhtungdu dinhtungdu linked a pull request Feb 17, 2020 that will close this issue
Bugfix/37 #38
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dinhtungdu dinhtungdu

Labels
help wanted type:enhancement New feature or request.
Projects
None yet
Milestone
2.3.3
Development

Successfully merging a pull request may close this issue.

Bugfix/37 asharirfan/simple-page-ordering
Fix: Avoid post__not_in 10up/simple-page-ordering
4 participants
@ryanwelcher @jeffpaul @dinhtungdu @nicholasio