Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Avoid post__not_in #39

Closed
wants to merge 1 commit into from
Closed

Fix: Avoid post__not_in #39

wants to merge 1 commit into from

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

Remove the usage of post__not_in and using php to filter excluded posts instead.

Alternate Designs

n/a

Benefits

See: https://10up.github.io/Engineering-Best-Practices/php/#performance

Possible Drawbacks

There may be a very edge case when

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #3

Changelog Entry

Changed: Remove post__not_in and use php to filter excluded post.

@dinhtungdu dinhtungdu marked this pull request as ready for review February 17, 2020 02:55
@dinhtungdu dinhtungdu self-assigned this Feb 17, 2020
@asharirfan
Copy link
Contributor

Hey @dinhtungdu 👋 I think, I already fixed it in #38 among other phpcs issues.

@dinhtungdu
Copy link
Contributor Author

dinhtungdu commented Feb 17, 2020

@asharirfan yes and ... I'm the one who reviewed it 🤦‍♂️, closing

@dinhtungdu dinhtungdu closed this Feb 17, 2020
@jeffpaul jeffpaul deleted the fix/3-post-not-int branch August 13, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid post__not_in
2 participants