Bugfix/37 #38
Bugfix/37 #38
Conversation
| 'update_post_term_cache' => false, | ||
| 'update_post_meta_cache' => false, | ||
| 'suppress_filters' => true, | ||
| 'suppress_filters' => true, // phpcs:ignore WordPressVIPMinimum.Performance.WPQueryParams.SuppressFiltersTrue |
There was a problem hiding this comment.
Set this to ignore the rule because I am pretty sure that we are ignoring caching while performing this query.
jeffpaul
added
type:enhancement
There was a problem hiding this comment.
LGTM. @pereirinha can you verify this PR with vipgo-ci?
P/s: I tried https://github.com/Automattic/VIP-Coding-Standards but couldn't produce the same error list as your comment.
P/s: I got this warning left after checking with phpcs and :
The "WordPress.WP.TimezoneChange" sniff has been deprecated. Use the "WordPress.DateTime.RestrictedFunctions" sniff instead. Please update your custom ruleset. (WordPress.WP.TimezoneChange.DeprecatedSniff)
simple-page-ordering.php
Outdated
| // no nonce to verify... | ||
| die( -1 ); | ||
| } else { | ||
| check_admin_referer( 'simple-page-ordering_' . sanitize_text_field( wp_unslash( $_POST['screen_id'] ) ) ); |
There was a problem hiding this comment.
this could be moved outside else. sanitize_text_field( wp_unslash can be placed by sanitize_key
I just ran the VIP-Coding-Standards and got the same results. The above-mentioned sniff has been discussed over here: Automattic/VIP-Coding-Standards#457 I hope this is helpful. Cheers 🙌 |
|
@dinhtungdu Seems that this PR is in good place? Any timeline for merging? |
|
@samikeijonen No exact timeline for now! But, we're preparing to release 2.3.3, so this will be merged along with other open PRs shortly. Personally, I'm expecting this week. |
|
@samikeijonen are you able to have VIP run this PR/branch to confirm it resolves all their issues before we merge and tag a release? |
|
Confirmed that preference from VIP was to review |
Description of the Change
These are fixes to the issues raised during the VIP GO review in #37
Verification Process
I have tested the plugin in a local WP environment after the changes.
Checklist:
Changelog Entry
Fixed various verification, sanitization and performance issues in the plugin.