-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Pre-commit hooks #41
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dinhtungdu can you resolve the conflicts here so we can work to get this and #42 merged? |
@jeffpaul sure! Fixed conflicts. |
I don't want to do this in a hotfix release, also seems to me if we're adding linting that should be added to CI. Punting to 2.4. |
jeffpaul
added a commit
that referenced
this pull request
Apr 8, 2020
Closing. We should implement #79 first then rework this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add pre-commit hooks and linters to keep the coding style of this project consistent and prevent potential syntax error early.
Alternate Designs
n/a
Benefits
New code is checked before committing.
Possible Drawbacks
We may need to update Github action workflows to match with new changes.
Verification Process
composer.json
andcomposer.lock
in repo.simple-page-ordering.php
, stage it, commit it, see the pre-commit hooks run.Checklist:
Applicable Issues
Closes #40
Changelog Entry