Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Pre-commit hooks #41

Closed
wants to merge 8 commits into from
Closed

Add: Pre-commit hooks #41

wants to merge 8 commits into from

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

Add pre-commit hooks and linters to keep the coding style of this project consistent and prevent potential syntax error early.

Alternate Designs

n/a

Benefits

New code is checked before committing.

Possible Drawbacks

We may need to update Github action workflows to match with new changes.

Verification Process

  • See new files composer.json and composer.lock in repo.
  • Make test changes to simple-page-ordering.php, stage it, commit it, see the pre-commit hooks run.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #40

Changelog Entry

@dinhtungdu dinhtungdu self-assigned this Feb 17, 2020
@dinhtungdu dinhtungdu marked this pull request as ready for review February 18, 2020 07:12
@jeffpaul jeffpaul added this to the 2.3.3 milestone Feb 18, 2020
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Feb 18, 2020
@dinhtungdu dinhtungdu requested a review from jeffpaul February 19, 2020 04:40
@jeffpaul jeffpaul modified the milestones: 2.3.3, 2.4.0 Mar 19, 2020
@jeffpaul
Copy link
Member

@dinhtungdu can you resolve the conflicts here so we can work to get this and #42 merged?

@dinhtungdu
Copy link
Contributor Author

@jeffpaul sure! Fixed conflicts.

@jeffpaul jeffpaul modified the milestones: 2.4.0, 2.3.4 Apr 7, 2020
@jeffpaul jeffpaul mentioned this pull request Apr 7, 2020
18 tasks
@helen helen modified the milestones: 2.3.4, 2.4.0 Apr 8, 2020
@helen
Copy link
Contributor

helen commented Apr 8, 2020

I don't want to do this in a hotfix release, also seems to me if we're adding linting that should be added to CI. Punting to 2.4.

@dinhtungdu
Copy link
Contributor Author

Closing. We should implement #79 first then rework this PR.

@dinhtungdu dinhtungdu closed this Feb 25, 2022
@jeffpaul jeffpaul removed this from the 2.4.0 milestone Mar 1, 2022
@jeffpaul jeffpaul deleted the add/40-precommit-hooks branch November 3, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add precommit hooks
3 participants