Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: WPAcceptance testing #42

Merged
merged 15 commits into from
Apr 7, 2020
Merged

Add: WPAcceptance testing #42

merged 15 commits into from
Apr 7, 2020

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

Add acceptance testing using 10up/wpacceptance.

Alternate Designs

n/a

Benefits

Give us more confidence when shipping releases.

Possible Drawbacks

n/a

Verification Process

See the CI passed.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

dinhtungdu
dinhtungdu commented Feb 18, 2020
View reviewed changes
Copy link
Contributor Author

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR depends on #36 merged to pass the CI.

@jeffpaul jeffpaul added this to the 2.3.3 milestone Feb 18, 2020
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Feb 18, 2020
@jeffpaul
Copy link
Member

@dinhtungdu the block on this PR from #36 should be gone now that 36 has been merged in

@dinhtungdu
Copy link
Contributor Author

@jeffpaul Yes, working on this to add more test cases

@dinhtungdu dinhtungdu marked this pull request as ready for review February 19, 2020 07:37
@dinhtungdu dinhtungdu requested a review from jeffpaul February 19, 2020 07:40
@dinhtungdu
Copy link
Contributor Author

@jeffpaul The test case for reordering child pages is falling, and it's expected behavior due to #43

jeffpaul
jeffpaul approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though probably best to hold off on merging until after the 2.3.3 release so that we don't throw off the VIP review of develop

@jeffpaul jeffpaul modified the milestones: 2.3.3, 2.4.0 Mar 19, 2020
@jeffpaul jeffpaul mentioned this pull request Mar 23, 2020
Closed
6 tasks
@jeffpaul jeffpaul modified the milestones: 2.4.0, 2.3.4 Apr 7, 2020
@jeffpaul jeffpaul mentioned this pull request Apr 7, 2020
Closed
18 tasks
@helen
Copy link
Contributor

helen commented Apr 7, 2020

I am merging this first - the tests will fail on develop, and then after merging #51 and #53 they should pass.

@helen helen merged commit a7273c6 into develop Apr 7, 2020
@helen helen deleted the try/wpacceptance branch April 7, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul jeffpaul approved these changes

Assignees

@dinhtungdu dinhtungdu

Labels
type:enhancement New feature or request.
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@dinhtungdu @jeffpaul @helen