Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make variancechecker() less ugly #1

Closed
2hands10fingers opened this issue Oct 25, 2018 · 5 comments
Closed

Make variancechecker() less ugly #1

2hands10fingers opened this issue Oct 25, 2018 · 5 comments

Comments

@2hands10fingers
Copy link
Owner

Currently the variancechecker() function is disgusting. Make it much more elegant and reduce line length. It can be found in packageparser.py

@CometS1
Copy link
Contributor

CometS1 commented Oct 25, 2018

I'll take a look at this

@CometS1
Copy link
Contributor

CometS1 commented Oct 25, 2018

Just a question, is elif i < 40 and i >= 35: suppose to give 4.0, not 3.5? Also. is elif i < 5 and i >= 0: suppose to give 15, not 0.5?

@CometS1
Copy link
Contributor

CometS1 commented Oct 25, 2018

@2hands10fingers Also, should 1000000 return 0.0095?

@2hands10fingers
Copy link
Owner Author

@CometS1 Good catch on the elif i < 40. It seems I accidentally skipped a number.

The elif i < 5 and i >= 0 is supposed to return 15, yes

2hands10fingers added a commit that referenced this issue Oct 27, 2018
Fix Issue #1, Cleaned up variancechecker function
@2hands10fingers
Copy link
Owner Author

Issue is now closed. Thanks everyone for adding their entries. @CometS1 takes the cake for cleanest and most functional approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants