forked from pingcap/tidb
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: Merge pingcap/br into pingcap/tidb with squash #2
Draft
3pointer
wants to merge
39
commits into
clone_br_squash
Choose a base branch
from
merge_br_squash
base: clone_br_squash
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3pointer
force-pushed
the
merge_br_squash
branch
2 times, most recently
from
July 27, 2021 09:49
3cf4c11
to
a327db2
Compare
2 tasks
3pointer
force-pushed
the
merge_br_squash
branch
2 times, most recently
from
August 2, 2021 02:40
0eff247
to
667f6c1
Compare
3pointer
force-pushed
the
clone_br_squash
branch
from
August 2, 2021 02:49
f141f98
to
e9c19a2
Compare
3pointer
force-pushed
the
merge_br_squash
branch
5 times, most recently
from
August 3, 2021 02:24
bbc6216
to
9f60546
Compare
3pointer
force-pushed
the
clone_br_squash
branch
from
August 3, 2021 04:06
e9c19a2
to
e9597a3
Compare
3pointer
force-pushed
the
merge_br_squash
branch
from
August 4, 2021 04:40
96ea84f
to
368152b
Compare
3pointer
force-pushed
the
clone_br_squash
branch
2 times, most recently
from
August 4, 2021 07:48
c614d48
to
e9597a3
Compare
3pointer
force-pushed
the
merge_br_squash
branch
2 times, most recently
from
August 4, 2021 08:25
9871c56
to
443a4b7
Compare
3pointer
force-pushed
the
clone_br_squash
branch
2 times, most recently
from
August 4, 2021 08:30
f87e91d
to
a75c234
Compare
3pointer
force-pushed
the
merge_br_squash
branch
2 times, most recently
from
August 4, 2021 08:32
f261b14
to
3bb533b
Compare
wjhuang2016
reviewed
Aug 4, 2021
"github.com/pingcap/br/pkg/task" | ||
"github.com/pingcap/br/pkg/utils" | ||
"github.com/pingcap/br/pkg/version/build" | ||
berrors "github.com/pingcap/tidb/br/pkg/errors" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the empty line
3pointer
force-pushed
the
merge_br_squash
branch
from
August 5, 2021 06:04
e0504b7
to
188a7bc
Compare
3pointer
force-pushed
the
clone_br_squash
branch
from
August 5, 2021 06:04
a75c234
to
1778c1a
Compare
3pointer
force-pushed
the
merge_br_squash
branch
from
August 5, 2021 06:09
188a7bc
to
79c5aa4
Compare
3pointer
force-pushed
the
merge_br_squash
branch
from
August 6, 2021 07:43
5a1c643
to
24e4722
Compare
…Aton/Inet6Ntoa/IsIPv4/IsIPv4Compat/IsIPv4Mapped/IsIPv6`. (pingcap#26939)
1b0e54c2f lightning: check and restore pd scheduler even if our task failed (pingcap#1336) 073d3596c lightning: fix the bug that calculate unfinished ranges may miss some range (pingcap#1413) 82ff927df backup: refine backup log for tracing backup tasks (pingcap#1335) e907562e8 lightning: make create table ddl compatible with clustered index (pingcap#1364) b6cab4b27 lightning: auto configure for parallel import (pingcap#1387) git-subtree-dir: br git-subtree-split: 1b0e54c2f2dca87bd0ad46201cbf27121e681b62
3pointer
force-pushed
the
merge_br_squash
branch
from
August 6, 2021 09:07
addae1f
to
6905240
Compare
3pointer
force-pushed
the
merge_br_squash
branch
from
August 6, 2021 09:22
6905240
to
b4a1e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
solve https://internals.tidb.io/t/topic/256/4
What is changed and how it works?
Merge BR repo into TiDB. and resolve the cycle dependence in BR and TiDB.
Check List
Tests
Side effects
Related changes