Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] THREESCALE-10164 Including the env var LARGE_CLIENT_HEADER_BUFFERS #1429

Closed

Conversation

perylemke
Copy link

@perylemke perylemke commented Nov 20, 2023

Include LARGE_CLIENT_HEADER_BUFFERS var to my first contribution on APICast.

Fixes https://issues.redhat.com/browse/THREESCALE-10164

@perylemke perylemke requested review from a team as code owners November 20, 2023 17:19
doc/parameters.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dfennessy dfennessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions to the paragraph.

Adding sugestion.

Co-authored-by: Darren Fennessy <[email protected]>
@eguzki eguzki changed the title Including the env var LARGE_CLIENT_HEADER_BUFFERS THREESCALE-10164 Including the env var LARGE_CLIENT_HEADER_BUFFERS Nov 20, 2023
@perylemke perylemke changed the title THREESCALE-10164 Including the env var LARGE_CLIENT_HEADER_BUFFERS [WIP] THREESCALE-10164 Including the env var LARGE_CLIENT_HEADER_BUFFERS Nov 20, 2023
Copy link
Contributor

@tkan145 tkan145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current code only reads the env var, you will need to also render the value to the apicast.conf.liquid file

For example

diff --git a/gateway/http.d/apicast.conf.liquid b/gateway/http.d/apicast.conf.liquid
index 93d60775..3f1df64c 100644
--- a/gateway/http.d/apicast.conf.liquid
+++ b/gateway/http.d/apicast.conf.liquid
@@ -134,6 +134,10 @@ server {
 
   {% include "http.d/ssl.conf" %}
 
+  {% if large_client_header_buffers != empty %}
+  large_client_header_buffers {{large_client_header_buffers}};
+  {% endif %}
+
   {% for file in "apicast.d/*.conf" | filesystem %}
     {% include file %}
   {% endfor %}

@eguzki
Copy link
Member

eguzki commented Jan 16, 2024

any progress on this issue?

@eguzki
Copy link
Member

eguzki commented Feb 13, 2024

Superseded by #1446

@eguzki eguzki closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants