Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] THREESCALE-10164 Including the env var LARGE_CLIENT_HEADER_BUFFERS #1429

Closed
wants to merge 2 commits into from
Closed

[WIP] THREESCALE-10164 Including the env var LARGE_CLIENT_HEADER_BUFFERS #1429

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a4fb61
Including the env var LARGE_CLIENT_HEADER_BUFFERS
perylemke Nov 20, 2023
6498eea
Update doc/parameters.md
perylemke Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions doc/parameters.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,13 @@ connections.
By default Gateway does not enable it, and the keepalive timeout on nginx is set
to [75 seconds](http://nginx.org/en/docs/http/ngx_http_core_module.html#keepalive_timeout)

### `LARGE_CLIENT_HEADER_BUFFERS`

**Default:** 4 8k
**Value:** string

Sets the maximum number and size of buffers used for reading large client request header. A request line cannot exceed the size of one buffer, or the 414 (Request-URI Too Large) error is returned to the client. A request header field cannot exceed the size of one buffer as well, or the 400 (Bad Request) error is returned to the client. Buffers are allocated only on demand. By default, the buffer size is equal to [8K](http://nginx.org/en/docs/http/ngx_http_core_module.html#large_client_header_buffers) bytes. If after the end of request processing a connection is transitioned into the keep-alive state, these buffers are released.
perylemke marked this conversation as resolved.
Show resolved Hide resolved


### `APICAST_CACHE_STATUS_CODES`

Expand Down
2 changes: 2 additions & 0 deletions gateway/src/apicast/cli/environment.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ _M.default_environment = 'production'
-- @tfield ?string opentelemetry_config_file opentelemetry config file to load
-- @tfield ?string upstream_retry_cases error cases where the call to the upstream should be retried
-- follows the same format as https://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_next_upstream
-- @tfield ?string large_client_header_buffers sets the maximum number and size of buffers used for reading large client request header
-- @tfield ?policy_chain policy_chain @{policy_chain} instance
-- @tfield ?{string,...} nameservers list of nameservers
-- @tfield ?string package.path path to load Lua files
Expand All @@ -149,6 +150,7 @@ _M.default_config = {
opentelemetry_config_file = env_value_ref('OPENTELEMETRY_CONFIG'),
upstream_retry_cases = env_value_ref('APICAST_UPSTREAM_RETRY_CASES'),
http_keepalive_timeout = env_value_ref('HTTP_KEEPALIVE_TIMEOUT'),
large_client_header_buffers = env_value_ref('LARGE_CLIENT_HEADER_BUFFERS'),
policy_chain = require('apicast.policy_chain').default(),
nameservers = parse_nameservers(),
worker_processes = cpus() or 'auto',
Expand Down