Minor change to handle a null buffer. #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fieldLength sets the length of the field name in the data structure to avoid repeated calls to strlen to determine the length of the string. relative is a void pointer that can be used to relate use cases specific information to the evidence pair. For example; storing data related to the evidence pair that could take a long time to retrieve.
…sent and if not will be handlded in the macro COLLECTION_RELEASE.
…x. When this flag is true then the data set post init method can be used to build an index to the first value for each property and profile which can be used to improve the performance of subsequent retrieval operations. There is a small penalty at startup to build the index. indexes.h/c contain the bulk of the impelementation. profile.h/c has been changed to add a new method called fiftyoneDegreesProfileIterateValuesForPropertyWithIndex that can use the index rather than a binary search to find the first value.
Uses the available properties collection to reduce the memory used for the index when fewer than the total number of properties are initialised. Offsets the profile indexes by the minimum profile id value to further reduce the memory used for the index. Provides two default configurations with and without the index flag set.
… creating the index.
…erformance improvement in practice.
…e.h within the json.c.
…ntation has been removed.
…ifferently. New tests to cover the modified implementation need to be added.
…ffer tracking for remaining space and reporting the number of characters that were or would be added. Needed to consolidate string building into a single set of methods across the projects.
FEAT: interop Transform generate a default ctor DOC: Transform.hpp, interop approach Co-authored-by: Eugene Dorfman <[email protected]>
…ry.h and the short form fiftyone.h. Now includes a direct reference to memory.h and uses the full name for Malloc.
…es the macro to create an array of key value pairs. # Conflicts: # pair.h
…ng header file. Uses this header file within transform.c to remove verbosity. Move some lines around for consistency with the rest of the project and modified some comments.
…ssert can result in a memory fault. Assert removed as there is not requirement for strings to be null terminated as the length is always provided.
…es to the array. There is no need to iterate over these additional values. The count of initial items is now used to limit the iterations rather than the current count of items in the array.
This reverts commit fea18f1.
…ot been needed in C/C++ code.
Refactored the method names to use "indices" to reflect the revised name of the file.
… FIFTYONE_DEGREES_EXCEPTIONS_DISABLED. Tests won't pass with this directive enabled as some rely on the exception to test the fidelity of the failure. This is expected. Some modification of transform.* requiired to support status codes where boolean return codes can't be used.
This reverts commit 5c06e71. +REFACT: use fiftyoneDegreesTransformIterateResult reintroduce exceptions after rebase
…e values associated with a profile and property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.