Minor change to handle a null buffer.

.github/workflows/nightly-pipeline.yml

@@ -1,7 +1,35 @@
-name: Nightly Pipeline (dummy)
-on: workflow_dispatch
+name: Nightly Pipeline
+
+on:
+  workflow_dispatch:
+    inputs:
+      dryrun:
+        type: boolean
+        default: false
+  schedule:
+    - cron: '5 0 * * *'
+
 jobs:
-  dummy:
-    runs-on: ubuntu-latest
-    steps:
-      - run: echo "This is a dummy action to allow actions with the same filename to run from other branches"
+  PullRequests:
+    name: Nightly Pull Requests
+    uses: postindustria-tech/common-ci/.github/workflows/nightly-pull-requests.yml@nightly-pipeline
+    with:
+      common-ci-ref: nightly-pipeline
+      repo-name: ${{ github.event.repository.name }}
+      org-name: ${{ github.event.repository.owner.login }}
+      dryrun: ${{ inputs.dryrun || false }}
+    secrets:
+      token: ${{ secrets.ACCESS_TOKEN }}
+
+  Publish:
+    if: ${{ !cancelled() }}
+    needs: PullRequests
+    name: Nightly Publish
+    uses: postindustria-tech/common-ci/.github/workflows/nightly-publish.yml@nightly-pipeline
+    with:
+      common-ci-ref: nightly-pipeline
+      repo-name: ${{ github.event.repository.name }}
+      org-name: ${{ github.event.repository.owner.login }}
+      dryrun: ${{ inputs.dryrun || false }}
+    secrets:
+      token: ${{ secrets.ACCESS_TOKEN }}

.github/workflows/scheduler.yml

@@ -0,0 +1,17 @@
+# Schedules nightly pipeline on non-main branches
+name: Nightly Pipeline Scheduler
+
+on:
+  schedule:
+    - cron: '5 0 * * *'
+
+jobs:
+  schedule:
+    runs-on: ubuntu-latest
+    permissions:
+      actions: write
+    env:
+      GH_TOKEN: ${{ github.token }}
+    steps:
+      - name: Schedule version/4.5
+        run: gh workflow run nightly-pipeline.yml --repo '${{ github.repository }}' --ref version/4.5

.gitignore

@@ -28,3 +28,15 @@ googletest*/
 *.CopyComplete
 *.iobj
 *.ipdb
+**/Debug
+**/Release
+**/bin
+**/CMakeFiles/
+**/CMakeCache.txt
+**/*.cmake
+**/DartConfiguration.tcl
+**/CMakeScripts/
+**/*.ninja*
+**/obj
+**/*.dll
+**/.vs

CMakeLists.txt

@@ -125,7 +125,7 @@ target_link_libraries(fiftyone-common-cxx fiftyone-common-c)
 set_target_properties(fiftyone-common-c fiftyone-common-cxx	PROPERTIES FOLDER "Common") 
 if (MSVC)
 	target_compile_options(fiftyone-common-c PRIVATE "/D_CRT_SECURE_NO_WARNINGS" "/W4" "/WX")
-	target_compile_options(fiftyone-common-cxx PRIVATE "/D_CRT_SECURE_NO_WARNINGS" "/W4" "/WX")
+	target_compile_options(fiftyone-common-cxx PRIVATE "/D_CRT_SECURE_NO_WARNINGS" "/W4" "/WX" "/EHsc")
 else ()
 	target_compile_options(fiftyone-common-c PRIVATE ${COMPILE_OPTION_DEBUG} "-Werror" "-Wno-atomic-alignment")
 	target_compile_options(fiftyone-common-cxx PRIVATE ${COMPILE_OPTION_DEBUG} "-Werror")
@@ -143,21 +143,21 @@ else ()
 	endif()
 endif()
 
-# Examples
-
-add_executable(CachePerf ${CMAKE_CURRENT_LIST_DIR}/performance/CachePerf.c)
-target_link_libraries(CachePerf	fiftyone-common-c)
-if (MSVC)
-	target_compile_options(CachePerf PRIVATE "/D_CRT_SECURE_NO_WARNINGS" "/W4" "/WX")
-	target_link_options(CachePerf PRIVATE "/WX")
-else ()
-	target_compile_options(CachePerf PRIVATE ${COMPILE_OPTION_DEBUG} "-Werror")
-endif()
-set_target_properties(CachePerf	PROPERTIES FOLDER "Examples/Common") 
-
 # Tests
+# BUILD_TESTING is true by default, but in some cases it is desirable to turn off
 
 if(BUILD_TESTING)
+	# Examples
+	add_executable(CachePerf ${CMAKE_CURRENT_LIST_DIR}/performance/CachePerf.c)
+	target_link_libraries(CachePerf	fiftyone-common-c)
+	if (MSVC)
+		target_compile_options(CachePerf PRIVATE "/D_CRT_SECURE_NO_WARNINGS" "/W4" "/WX")
+		target_link_options(CachePerf PRIVATE "/WX")
+	else ()
+		target_compile_options(CachePerf PRIVATE ${COMPILE_OPTION_DEBUG} "-Werror")
+	endif()
+	set_target_properties(CachePerf	PROPERTIES FOLDER "Examples/Common") 
+
 	# Download and unpack googletest at configure time
 	configure_file(${CMAKE_CURRENT_LIST_DIR}/CMakeLists.txt.in googletest-download/CMakeLists.txt)
 	execute_process(COMMAND ${CMAKE_COMMAND} -G "${CMAKE_GENERATOR}" .

ConfigBase.cpp

@@ -52,6 +52,10 @@ void ConfigBase::setTempDirectories(
 	mapTempDirectories();
 }
 
+void ConfigBase::setPropertyValueIndex(bool index) {
+	this->config->propertyValueIndex = index;
+}
+
 bool ConfigBase::getUseUpperPrefixHeaders() const {
 	return config->usesUpperPrefixedHeaders;
 }
@@ -68,6 +72,10 @@ vector<string> ConfigBase::getTempDirectories() const {
 	return tempDirs;
 }
 
+bool ConfigBase::getPropertyValueIndex() const {
+	return config->propertyValueIndex;
+}
+
 uint16_t ConfigBase::getConcurrency() const {
 	return 0;
 }

ConfigBase.hpp

@@ -113,6 +113,13 @@ namespace FiftyoneDegrees {
 			 */
 			void setTempDirectories(vector<string> tempDirs);
 
+			/**
+			 * Set whether or not an index to speed up the retrieval of values
+			 * for profiles and properties is created.
+			 * @param index should create an index
+			 */
+			void setPropertyValueIndex(bool index);
+
 			/**
 			 * @}
 			 * @name Getters
@@ -149,6 +156,13 @@ namespace FiftyoneDegrees {
 			 */
 			vector<string> getTempDirectories() const;
 
+			/**
+			 * Gets a flag indicating if an index of values for properties and
+			 * profile is created.
+			 * @return true if an index should be created, or false if not.
+			 */
+			bool getPropertyValueIndex() const;
+
 			/**
 			 * Get the expected number of concurrent accessors of the data set.
 			 * @return concurrency

Exceptions.cpp

@@ -57,14 +57,22 @@ fiftyoneDegreesStatusCode StatusCodeException::getCode() const noexcept {
 	return statusCode;
 }
 
+#ifndef FIFTYONE_DEGREES_EXCEPTIONS_DISABLED 
 FatalException::FatalException(
-	fiftyoneDegreesException *exception) : StatusCodeException() {
+    fiftyoneDegreesException *exception) : StatusCodeException(exception->status) {
 	const char *exceptionMessage = ExceptionGetMessage(exception);
 	if (exceptionMessage != nullptr) {
 		message.append(exceptionMessage);
 		Free((void*)exceptionMessage);
 	}
 }
+#else 
+FatalException::FatalException(
+	fiftyoneDegreesException* exception) : StatusCodeException(NOT_SET) {
+	message.append(
+		"Exceptions disabled with FIFTYONE_DEGREES_EXCEPTIONS_DISABLED");
+}
+#endif
 
 NotImplementedException::NotImplementedException() 
 	: runtime_error("Function not yet implemented") { 

README.md

@@ -154,4 +154,4 @@ mkdir -p coverage; gcovr --html-detail -o coverage/coverage.html; open coverage/
 To check the summary run:
 ```
 gcovr -r . --print-summary
-```
+```

VisualStudio/FiftyOne.Common.C/FiftyOne.Common.C.vcxproj

@@ -19,7 +19,9 @@
     <ClInclude Include="..\..\float.h" />
     <ClInclude Include="..\..\headers.h" />
     <ClInclude Include="..\..\ip.h" />
+    <ClInclude Include="..\..\json.h" />
     <ClInclude Include="..\..\list.h" />
+    <ClInclude Include="..\..\indices.h" />
     <ClInclude Include="..\..\memory.h" />
     <ClInclude Include="..\..\overrides.h" />
     <ClInclude Include="..\..\pair.h" />
@@ -28,7 +30,6 @@
     <ClInclude Include="..\..\profile.h" />
     <ClInclude Include="..\..\properties.h" />
     <ClInclude Include="..\..\property.h" />
-    <ClInclude Include="..\..\pseudoheader.h" />
     <ClInclude Include="..\..\resource.h" />
     <ClInclude Include="..\..\results.h" />
     <ClInclude Include="..\..\snprintf.h" />
@@ -53,15 +54,16 @@
     <ClCompile Include="..\..\float.c" />
     <ClCompile Include="..\..\headers.c" />
     <ClCompile Include="..\..\ip.c" />
+    <ClCompile Include="..\..\json.c" />
     <ClCompile Include="..\..\list.c" />
+    <ClCompile Include="..\..\indices.c" />
     <ClCompile Include="..\..\memory.c" />
     <ClCompile Include="..\..\overrides.c" />
     <ClCompile Include="..\..\pool.c" />
     <ClCompile Include="..\..\process.c" />
     <ClCompile Include="..\..\profile.c" />
     <ClCompile Include="..\..\properties.c" />
     <ClCompile Include="..\..\property.c" />
-    <ClCompile Include="..\..\pseudoheader.c" />
     <ClCompile Include="..\..\resource.c" />
     <ClCompile Include="..\..\results.c" />
     <ClCompile Include="..\..\status.c" />

VisualStudio/FiftyOne.Common.C/FiftyOne.Common.C.vcxproj.filters

@@ -126,6 +126,9 @@
     <ClInclude Include="..\..\yamlfile.h">
       <Filter>Header Files</Filter>
     </ClInclude>
+    <ClInclude Include="..\..\indices.h">
+      <Filter>Header Files</Filter>
+    </ClInclude>
   </ItemGroup>
   <ItemGroup>
     <ClCompile Include="..\..\cache.c">
@@ -218,5 +221,8 @@
     <ClCompile Include="..\..\yamlfile.c">
       <Filter>Source Files</Filter>
     </ClCompile>
+    <ClCompile Include="..\..\indexes.c">
+      <Filter>Source Files</Filter>
+    </ClCompile>
   </ItemGroup>
 </Project>

VisualStudio/Fiftyone.Common.Tests/Fiftyone.Common.Tests.vcxproj

@@ -41,7 +41,6 @@
     <ClCompile Include="..\..\tests\PoolTests.cpp" />
     <ClCompile Include="..\..\tests\PropertiesTests.cpp" />
     <ClCompile Include="..\..\tests\PropertyMetaDataTests.cpp" />
-    <ClCompile Include="..\..\tests\PseudoHeaderTests.cpp" />
     <ClCompile Include="..\..\tests\RequiredPropertiesConfigTests.cpp" />
     <ClCompile Include="..\..\tests\ResourceManagerTests.cpp" />
     <ClCompile Include="..\..\tests\StatusTests.cpp" />
@@ -51,6 +50,7 @@
     <ClCompile Include="..\..\tests\ThreadingTests.cpp" />
     <ClCompile Include="..\..\tests\ValueTests.cpp" />
     <ClCompile Include="..\..\tests\YamlFileTests.cpp" />
+    <ClCompile Include="..\..\tests\HeadersContainer.cpp" />
   </ItemGroup>
   <ItemGroup>
     <ClInclude Include="..\..\tests\Base.hpp" />
@@ -59,9 +59,11 @@
     <ClInclude Include="..\..\tests\ExampleTests.hpp" />
     <ClInclude Include="..\..\tests\FileHandle.hpp" />
     <ClInclude Include="..\..\tests\pch.h" />
-    <ClInclude Include="..\..\tests\PseudoHeaderTests.hpp" />
     <ClInclude Include="..\..\tests\StringCollection.hpp" />
     <ClInclude Include="..\..\tests\TestStrings.hpp" />
+    <ClInclude Include="..\..\tests\FixedSizeCollection.hpp" />
+    <ClInclude Include="..\..\tests\VariableSizeCollection.hpp" />
+    <ClInclude Include="..\..\tests\HeadersContainer.hpp" />
   </ItemGroup>
   <ImportGroup Label="ExtensionTargets">
     <Import Project="..\packages\Microsoft.googletest.v140.windesktop.msvcstl.static.rt-dyn.1.8.1.7\build\native\Microsoft.googletest.v140.windesktop.msvcstl.static.rt-dyn.targets" Condition="Exists('..\packages\Microsoft.googletest.v140.windesktop.msvcstl.static.rt-dyn.1.8.1.7\build\native\Microsoft.googletest.v140.windesktop.msvcstl.static.rt-dyn.targets')" />

VisualStudio/Fiftyone.Common.Tests/Fiftyone.Common.Tests.vcxproj.filters

@@ -99,9 +99,6 @@
     <ClCompile Include="..\..\tests\OverridesTests.cpp">
       <Filter>Source Files</Filter>
     </ClCompile>
-    <ClCompile Include="..\..\tests\PseudoHeaderTests.cpp">
-      <Filter>Source Files</Filter>
-    </ClCompile>
     <ClCompile Include="..\..\tests\TextFileTests.cpp">
       <Filter>Source Files</Filter>
     </ClCompile>
@@ -140,8 +137,5 @@
     <ClInclude Include="..\..\tests\TestStrings.hpp">
       <Filter>Header Files</Filter>
     </ClInclude>
-    <ClInclude Include="..\..\tests\PseudoHeaderTests.hpp">
-      <Filter>Header Files</Filter>
-    </ClInclude>
   </ItemGroup>
 </Project>

array.h

@@ -40,6 +40,9 @@
  * @{
  */
 
+#include <stdint.h>
+#include "memory.h"
+
 /**
  * Simple array structure definition macro used for generic types.
  * @param t type of item
@@ -51,7 +54,7 @@
 typedef struct fiftyone_degrees_array_##t##_t { \
 	uint32_t count; /**< Number of used items */ \
 	uint32_t capacity; /**< Number of available items */ \
-	t *items; /**< Pointer to the first item */ \
+	t* items; /**< Pointer to the first item */ \
 	m /**< Add any members provided by the caller */ \
 } t##Array;
 
@@ -64,7 +67,7 @@ typedef struct fiftyone_degrees_array_##t##_t { \
  * Initialises the array.
  */
 #define FIFTYONE_DEGREES_ARRAY_CREATE(t, i, c) \
-i = (t##Array*)Malloc(FIFTYONE_DEGREES_ARRAY_SIZE(t,c)); \
+i = (t##Array*)fiftyoneDegreesMalloc(FIFTYONE_DEGREES_ARRAY_SIZE(t,c)); \
 if (i != NULL) { \
 i->items = (t*)(i + 1); \
 i->count = 0; \

cache.c

@@ -21,7 +21,6 @@
  * ********************************************************************* */
 
 #include "cache.h"
-
 #include "fiftyone.h"
 
 /**

common.h

@@ -41,4 +41,10 @@
 #define EXTERNAL_VAR extern
 #endif
 
+// The characters at the start of a cookie or other storage key that indicate
+// the item is related to 51Degrees.
+#ifndef FIFTYONE_DEGREES_COMMON_COOKIE_PREFIX
+#define FIFTYONE_DEGREES_COMMON_COOKIE_PREFIX "51D_"
+#endif
+
 #endif