Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stats page #214

Merged
merged 3 commits into from
Mar 1, 2025
Merged

Improve stats page #214

merged 3 commits into from
Mar 1, 2025

Conversation

dektar
Copy link
Collaborator

@dektar dektar commented Mar 1, 2025 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization

Description

  • Show graph only after a few days of calls have happened
  • Show top issues before contacts
  • Don't share graph if there isn't one
  • Clean-up some android studio warnings

Related Issues

Were the changes tested?

  • Yes, automated tests in please name test methods or files
  • Yes, manually tested: Tested on Nexus 5x and Pixel 6a with assorted numbers of historical calls. including share.
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

@dektar
Stats page improvements
64ab2c1 
* Show graph only after a few days of calls have happened
* Show top issues before contacts
* Don't share graph if there isn't one
@dektar
Update share intent with no graph to have type
f70683f
@dektar
Clean up StatsActivity: Format, remove extra share, optimize imports,…
ff09d3e 
… etc
@dektar dektar requested a review from brericha March 1, 2025 03:23
@dektar dektar merged commit 1e6dc9b into master Mar 1, 2025
1 check passed
@dektar dektar deleted the stats branch March 1, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brericha brericha brericha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

To continue to encourage daily calls, show stats per issue in the stats activity
2 participants
@dektar @brericha