Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acme-lsp doesn't work in Windows #14

Closed
fhs opened this issue Aug 26, 2019 · 1 comment
Closed

acme-lsp doesn't work in Windows #14

fhs opened this issue Aug 26, 2019 · 1 comment
Assignees
@fhs
Labels
bug Something isn't working

Comments

@fhs
Copy link
Collaborator

fhs commented Aug 26, 2019

Acme-lsp should work fine in Edwood (Go port of acme), but it doesn't work on Windows because it has no plumber. See rjkroege/edwood#48 (comment).

This is one reason to move to using 9P (or something else?) for communication between L and acme-lsp, instead of using the plumber. Jump-to-definition (L def) still won't work without a plumber but at least it can print the location. Ultimately, someone needs to port the plumber to Windows for good editing experience.
@fhs fhs added the bug Something isn't working label Aug 26, 2019
@fhs fhs mentioned this issue Aug 26, 2019
Open
fhs added a commit that referenced this issue Sep 9, 2019
@fhs
Use jsonrpc2 for communication between acme-lsp and L
f48d557 
The plumber has been replaced with jsonrpc2 over a unix domain socket at
`$(namespace)/acme-lsp.rpc`. The RPC messages are currently similar to a
plumb message, but the plan is to change the messages to be a subset of
the LSP protocol.

We still depends on the plumber for `L def` and `L type`.

Update #14
@fhs fhs self-assigned this Sep 9, 2019
fhs added a commit that referenced this issue Sep 12, 2019
@fhs
Remove plumber setup instructions from documentation
7575cf2 
Help #14
fhs added a commit that referenced this issue Sep 23, 2019
@fhs
cmd/acme-lsp, cmd/L: add -proxy.net and -proxy.addr flags
b4927ab 
Helps #14
fhs added a commit that referenced this issue Sep 23, 2019
@fhs
cmd: add -acme.net and -acme.addr flags
622f0d3 
Helps #14
fhs added a commit that referenced this issue Sep 24, 2019
@fhs
internal/acme: fork 9fans.net/go/acme in order to support custom address
0c2a38a 
Needed for Windows support. A fork is necessary because it's not
possible to create a Window from a client.Fid without assuming p9p
namespace.

Helps #14
fhs added a commit that referenced this issue Sep 24, 2019
@fhs
all: use span package for conversion between URI and filename
cdcd74d 
This fixes Windows path conversion.

Helps #14
@fhs fhs changed the title acme-lsp doesn't work without plumber (e.g in Windows) acme-lsp doesn't work in Windows Sep 24, 2019
@fhs fhs mentioned this issue Sep 24, 2019
Merged
fhs added a commit that referenced this issue Oct 8, 2019
@fhs
cmd/L: add -p flag to 'def' and 'type' sub-commands
ca2d338 
Helpful in Windows, where there is no plumber (issue #14).
@fhs
Copy link
Collaborator Author

fhs commented Oct 8, 2019

acme-lsp should work with the new release I just tagged. You need to set ProxyAddress, AcmeAddress, etc. in the config file or pass them from the command line.

I need to do more testing with unix domain sockets in Windows 10, and if it works well, we may be able to discover the addresses from the NAMESPACE environment variable.

@fhs fhs closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fhs fhs

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fhs