Fix some Windows issues #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't have any authentication and some libraries get Uname wrong anyway, allow Uname mismatch.
This allows user to listen to a specified port instead of a random one.
os.UserHomeDir() was introduced in Go 1.12. Update rjkroege#222
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=========================================
+ Coverage 51.13% 51.54% +0.4%
=========================================
Files 47 47
Lines 10195 10116 -79
=========================================
+ Hits 5213 5214 +1
+ Misses 4591 4511 -80
Partials 391 391
Continue to review full report at Codecov.
|
rjkroege
approved these changes
Sep 26, 2019
| @@ -275,7 +276,12 @@ func (fs *fileServer) flush(x *Xfid, f *Fid) *Xfid { | |||
|
|
|||
| func (fs *fileServer) attach(x *Xfid, f *Fid) *Xfid { | |||
| if x.fcall.Uname != fs.username { | |||
| return fs.respond(x, nil, ErrPermission) | |||
| // Ignore mismatch because some libraries gets it wrong | |||
|
Thanks for the awesome fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unamemismatch inTattach, since we don't have any authentication and some libraries (e.g.9fans.net/go/plan9/client) getsUnamewrong anyway.-fsys.addrflag for Windows. This allows user to listen to a specified port instead of a random one.$HOMEwithos.UserHomeDir(), which was introduced in Go 1.12. Update Default location of dump file #222Helps 9fans/acme-lsp#14