Increase cyclefactor for region ai_TM1 SPW33 #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
keflavich
approved these changes
Jan 17, 2023
|
@d-l-walker could you check what happened here - I merged this, but it claimed that there was a conflict because something else added in a lot of custom parameters. |
|
@keflavich I'm not sure why ... in my initial commit I literally changed 1.0 -> 2.0 for the cyclefactor. I'll look at this more carefully to see if I can figure out what's happened, but I don't know off the top of my head |
|
it looks like something I did (automatically) that caused the conflict. But, I don't quite understand the order of operations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPW 33 for Sgr_A_st_ai_03_TM1 (#130) diverged with default values. I reprocessed changing only
cyclefactor=1.0->cyclefactor=2.0, which is reflected in this PR.