Fix MSVC builds / remove -W* flags #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes `-W` compiler flags on Windows, which aren't understood by MSVC. Fixes `cl : Command line error D8021 : invalid numeric argument '/Werror'` (which for some reason currently only occurs on branch `adjoint_event` 🤷♂️) See also https://learn.microsoft.com/en-us/cpp/build/reference/wx-treat-linker-warnings-as-errors?view=msvc-170
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1972 +/- ##
========================================
Coverage 75.98% 75.98%
========================================
Files 76 76
Lines 12984 12986 +2
========================================
+ Hits 9866 9868 +2
Misses 3118 3118
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
-Wcompiler flags on Windows, which aren't understood by MSVC.Fixes
cl : Command line error D8021 : invalid numeric argument '/Werror'(which for some reason currently only occurs on branchadjoint_event🤷♂️)See also https://learn.microsoft.com/en-us/cpp/build/reference/wx-treat-linker-warnings-as-errors?view=msvc-170