Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSVC builds / remove -W* flags #1972

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Fix MSVC builds / remove -W* flags #1972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions python/sdist/amici/setuptools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,13 @@ def add_debug_flags_if_required(cxx_flags: List[str],
and os.environ['ENABLE_AMICI_DEBUGGING'] == 'TRUE':
print("ENABLE_AMICI_DEBUGGING was set to TRUE."
" Building AMICI with debug symbols.")
cxx_flags.extend(['-g', '-O0', '-UNDEBUG', '-Werror',
'-Wno-error=deprecated-declarations'])
cxx_flags.extend(['-g', '-O0', '-UNDEBUG'])
if sys.platform != "win32":
# these options are incompatible with MSVC, but there is no easy
# way to detect which compiler will be used. so we just skip them
# altogether on windows.
cxx_flags.extend(['-Werror', '-Wno-error=deprecated-declarations'])

linker_flags.extend(['-g'])


Expand Down