Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sympy DeprecationWarning #2131

Merged
merged 3 commits into from
Jun 24, 2023
Merged

Fix sympy DeprecationWarning #2131

merged 3 commits into from
Jun 24, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 23, 2023

During SBML test case 01288 when handling true/false:

E       sympy.utilities.exceptions.SymPyDeprecationWarning:
E
E       non-Expr objects in a Matrix is deprecated. Matrix represents
E       a mathematical matrix. To represent a container of non-numeric
E       entities, Use a list of lists, TableForm, NumPy array, or some
E       other data structure instead.
E
E       See https://docs.sympy.org/latest/explanation/active-deprecations.html#deprecated-non-expr-in-matrix
E       for details.
E
E       This has been deprecated since SymPy version 1.9. It
E       will be removed in a future version of SymPy.

During SBML test case 01288:

```
E       sympy.utilities.exceptions.SymPyDeprecationWarning:
E
E       non-Expr objects in a Matrix is deprecated. Matrix represents
E       a mathematical matrix. To represent a container of non-numeric
E       entities, Use a list of lists, TableForm, NumPy array, or some
E       other data structure instead.
E
E       See https://docs.sympy.org/latest/explanation/active-deprecations.html#deprecated-non-expr-in-matrix
E       for details.
E
E       This has been deprecated since SymPy version 1.9. It
E       will be removed in a future version of SymPy.
```
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #2131 (537281a) into develop (e744b5c) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2131   +/-   ##
========================================
  Coverage    54.38%   54.38%           
========================================
  Files           33       33           
  Lines         5518     5518           
========================================
  Hits          3001     3001           
  Misses        2517     2517           
Flag Coverage Δ
petab 54.38% <100.00%> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/sbml_import.py 59.55% <100.00%> (ø)

@dweindl dweindl marked this pull request as ready for review June 24, 2023 09:17
@dweindl dweindl requested a review from a team as a code owner June 24, 2023 09:17
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 773f8d2 into develop Jun 24, 2023
@dweindl dweindl deleted the fix_bool_conv branch June 24, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants