-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade all components to React 18 and combine header and footer #1377
Merged
davidornelas11
merged 107 commits into
component-consolidation
from
rebase-component-consolidation
Oct 8, 2024
Merged
Upgrade all components to React 18 and combine header and footer #1377
davidornelas11
merged 107 commits into
component-consolidation
from
rebase-component-consolidation
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a navtree link does not have an href, check to make sure onclick is called
Uds 1793: Fix onclick in header navtree
fix(unity-bootstrap-theme): added css for long pagination on mobile
UDS-1783: Add caption styles for tables
fix(app-rfi): Update Military to radio button
fix(app-rfi): update plan title to use market description
feat(app-rfi): only display plan if rfiDisplay true
# [@asu/app-rfi-v2.4.0](https://github.com/asu/asu-unity-stack/compare/@asu/app-rfi-v2.3.13...@asu/app-rfi-v2.4.0) (2024-09-25) ### Features * **app-rfi:** only display plan if rfiDisplay true ([2527a58](2527a58)) * **app-rfi:** RFI form not displayed message ([0dfe49c](0dfe49c)) * **app-rfi:** rfiDisplay false renders blank ([9f1983a](9f1983a))
chore(monorepo): Update git ignored files
fix(component-header): fix dataLayer firing on parent dropdown click
# [@asu/component-header-v2.3.3](https://github.com/asu/asu-unity-stack/compare/@asu/component-header-v2.3.2...@asu/component-header-v2.3.3) (2024-10-03) ### Bug Fixes * **component-header:** change onFocus to onClick for type definitions ([9634a97](9634a97)) * **component-header:** fix all dataLayer events in header ([342f825](342f825)) * **component-header:** fix dataLayer firing on parent dropdown click ([7bc6d32](7bc6d32)) * **component-header:** fix logo onClick ([faf982a](faf982a)) * **component-header:** missing data layer for logo when partner not used ([5e65efc](5e65efc)) * **component-header:** remove duplicate props ([fb071d3](fb071d3))
improve submitting check with useState
Erfi submit dupe prevention
# [@asu/app-rfi-v2.4.1](https://github.com/asu/asu-unity-stack/compare/@asu/app-rfi-v2.4.0...@asu/app-rfi-v2.4.1) (2024-10-04) ### Bug Fixes * **app-rfi:** account for steps counting as submits ([24abdfd](24abdfd)) * **app-rfi:** get prop type right ([2192fd9](2192fd9)) * **app-rfi:** missing prop update ([57855a8](57855a8)) * **app-rfi:** remove timeout for testing. add prop definition. linting fixes ([ad7bd44](ad7bd44)) * **app-rfi:** use submitCount to prevent dupes ([09274ae](09274ae))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade all components to React 18 and combine header and footer
Links
FOR APPROVERS