Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Encapsulate Shiki logic in useShiki hook #463

Draft
wants to merge 2 commits into
base: shikiWithParser
Choose a base branch
from
Draft

refactor: Encapsulate Shiki logic in useShiki hook #463

wants to merge 2 commits into from

Conversation

AVGVSTVS96
Copy link
Owner

@AVGVSTVS96 AVGVSTVS96 commented Jun 29, 2024 •
edited
Loading

Create useShiki hook, use in CodeHighlight component

styling: update code theme to 'houston'

update lockfiles

@AVGVSTVS96
Create useShiki hook, use in CodeHighlight component
f69cd29 
- Create `useShiki` hook to handle code highlighting logic
- Call `useShiki` hook in `CodeHighlight` component
- Remove unneeded props and imports from `CodeHighlight` component
@codesandbox CodeSandbox
Copy link

codesandbox bot commented Jun 29, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

This was referenced Jun 29, 2024
Closed
Closed
Closed
@AVGVSTVS96 Graphite App
Copy link
Owner Author

AVGVSTVS96 commented Jun 29, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@AVGVSTVS96 AVGVSTVS96 mentioned this pull request Jun 29, 2024
Draft
@AVGVSTVS96 AVGVSTVS96 changed the title Simplify CodeHighlight and useShiki hook, update code block styling Encapsulate Shiki logic in useShiki hook Jun 29, 2024
@AVGVSTVS96 AVGVSTVS96 force-pushed the shikiHookWithParse branch from 87ac4bd to e2aad91 Compare June 30, 2024 01:17
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jun 30, 2024 •
edited
Loading

Deploying astrosite with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2f8abe7
Status:🚫  Deploy failed.

View logs

@AVGVSTVS96 AVGVSTVS96 changed the title Encapsulate Shiki logic in useShiki hook refactor: Encapsulate Shiki logic in useShiki hook Jul 1, 2024
@AVGVSTVS96 AVGVSTVS96 force-pushed the shikiHookWithParse branch from e2aad91 to 4bce9a9 Compare July 1, 2024 03:49
@AVGVSTVS96 AVGVSTVS96 force-pushed the shikiHookWithParse branch from 4bce9a9 to 019a11b Compare July 1, 2024 03:51
@AVGVSTVS96 AVGVSTVS96 mentioned this pull request Jul 4, 2024
Draft
@AVGVSTVS96 AVGVSTVS96 force-pushed the shikiHookWithParse branch 2 times, most recently from 873452f to 9ac24cc Compare July 4, 2024 02:47
@AVGVSTVS96 AVGVSTVS96 force-pushed the shikiHookWithParse branch from 7655274 to 2ecfe55 Compare July 4, 2024 03:27
@AVGVSTVS96 AVGVSTVS96 mentioned this pull request Jul 4, 2024
Merged
@AVGVSTVS96 AVGVSTVS96 force-pushed the shikiHookWithParse branch from 2ecfe55 to fbe698d Compare July 4, 2024 05:56
@AVGVSTVS96 AVGVSTVS96 force-pushed the shikiHookWithParse branch 3 times, most recently from be5e659 to 518b71e Compare July 5, 2024 04:00
@AVGVSTVS96 AVGVSTVS96 force-pushed the shikiHookWithParse branch from 1cb90ed to 00b9025 Compare July 5, 2024 05:37
@AVGVSTVS96 AVGVSTVS96 force-pushed the shikiHookWithParse branch from 00b9025 to d94c5ca Compare July 5, 2024 23:58
This was referenced Jan 28, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AVGVSTVS96