Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use react-shiki from package #567

Open
wants to merge 2 commits into
base: customThemeShiki
Choose a base branch
from

Conversation

AVGVSTVS96
Copy link
Owner

@AVGVSTVS96 AVGVSTVS96 commented Jan 28, 2025

TL;DR

Switched code highlighting implementation to use my new react-shiki package

this description was written in part by graphite's AI

What changed?

  • Added react-shiki as a linked local dependency
  • Updated code highlighting import to use the new package instead of local implementation

How to test?

  1. Ensure code highlighting still works in chat UI
  2. Verify syntax highlighting appears correctly for both inline and block code
  3. Confirm the custom and shiki themes are still properly applied

Why make this change?

Moving the Shiki implementation to my package improves modularity and allows me to maintain this functionality independent of this project.

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
astro-portfolio-site ❌ Failed (Inspect) Feb 8, 2025 4:36am

Copy link

codesandbox bot commented Jan 28, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Owner Author

AVGVSTVS96 commented Jan 28, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant