Update DG with the correct diagram names #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #127 +/- ##
=========================================
Coverage 71.11% 71.11%
Complexity 479 479
=========================================
Files 79 79
Lines 1662 1662
Branches 160 160
=========================================
Hits 1182 1182
Misses 419 419
Partials 61 61 ☔ View full report in Codecov by Sentry. |
jiahui0309
approved these changes
Mar 27, 2024
| @@ -185,7 +185,7 @@ Step 2. The user executes `add n/John Doe …` to add the person in the address | |||
|
|
|||
| The following sequence diagram shows how an undo operation goes through the `Logic` component: | |||
|
|
|||
| <puml src="diagrams/AddCommandSequenceDiagram.puml" alt="AddCommandSequenceDiagram" /> | |||
| <puml src="diagrams/AddCommandDiagram.puml" alt="AddCommandDiagram" /> | |||
| @@ -312,7 +312,7 @@ The following sequence diagram shows how a find operation goes through the `Logi | |||
|
|
|||
| The following activity diagram summarizes what happens when a user executes a new command: | |||
|
|
|||
| <puml src="diagrams/FindCommandActivityDiagram.puml" width="250" /> | |||
| <puml src="diagrams/FindCommandActivityDiagram.puml" width="250" align="center"/> | |||
There was a problem hiding this comment.
I think this nicely centralizes the image :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the naming of diagrams to fix the broken images on the website.
Closes #126.