forked from nus-cs2103-AY2324S2/tp
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DG with the correct diagram names #127
Merged
tengcharmaine
merged 1 commit into
AY2324S2-CS2103T-F14-2:master
from
tengcharmaine:dg_broken
Mar 27, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -185,7 +185,7 @@ Step 2. The user executes `add n/John Doe …` to add the person in the address | |
|
||
The following sequence diagram shows how an undo operation goes through the `Logic` component: | ||
|
||
<puml src="diagrams/AddCommandSequenceDiagram.puml" alt="AddCommandSequenceDiagram" /> | ||
<puml src="diagrams/AddCommandDiagram.puml" alt="AddCommandDiagram" /> | ||
|
||
<box type="info" seamless> | ||
|
||
|
@@ -195,7 +195,7 @@ The following sequence diagram shows how an undo operation goes through the `Log | |
|
||
The following activity diagram summarizes what happens when a user executes a new command: | ||
|
||
<puml src="diagrams/AddCommandActivityDiagram.puml" width="250" /> | ||
<puml src="diagrams/AddCommandActivityDiagram.puml" width="250" align="center"/> | ||
|
||
#### Design Considerations & Alternatives Considered: | ||
|
||
|
@@ -255,7 +255,7 @@ The following sequence diagram shows how an addnote operation goes through the ` | |
|
||
The following activity diagram summarizes what happens when a user executes a new command: | ||
|
||
<puml src="diagrams/AddNoteCommandActivityDiagram.puml" width="250" /> | ||
<puml src="diagrams/AddNoteCommandActivityDiagram.puml" width="250" align="center"/> | ||
|
||
#### Design Considerations & Alternatives Considered | ||
|
||
|
@@ -312,7 +312,7 @@ The following sequence diagram shows how a find operation goes through the `Logi | |
|
||
The following activity diagram summarizes what happens when a user executes a new command: | ||
|
||
<puml src="diagrams/FindCommandActivityDiagram.puml" width="250" /> | ||
<puml src="diagrams/FindCommandActivityDiagram.puml" width="250" align="center"/> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this nicely centralizes the image :) |
||
|
||
#### Design Considerations & Alternatives Considered | ||
|
||
|
@@ -347,7 +347,7 @@ The delete command calls `Model#deletePerson(Person target)`, causing the modifi | |
|
||
The following sequence diagram shows how a delete operation goes through the `Logic` component: | ||
|
||
<puml src="diagrams/DeleteSequenceDiagram.puml" alt="FindSequenceDiagram" /> | ||
<puml src="diagrams/DeleteSequenceDiagram.puml" alt="DeleteSequenceDiagram" /> | ||
|
||
<box type="info" seamless> | ||
|
||
|
@@ -357,7 +357,7 @@ The following sequence diagram shows how a delete operation goes through the `Lo | |
|
||
The following activity diagram summarizes what happens when a user executes a new command: | ||
|
||
<puml src="diagrams/DeleteCommandActivityDiagram.puml" width="250" /> | ||
<puml src="diagrams/DeleteCommandActivityDiagram.puml" width="250" align="center"/> | ||
|
||
#### Design Considerations & Alternatives Considered | ||
|
||
|
@@ -401,7 +401,7 @@ The following sequence diagram shows how an edit operation goes through the `Log | |
|
||
The following activity diagram summarizes what happens when a user executes a new command: | ||
|
||
<puml src="diagrams/EditCommandActivityDiagram.puml" width="250" /> | ||
<puml src="diagrams/EditCommandActivityDiagram.puml" width="250" align="center"/> | ||
|
||
#### Design Considerations & Alternatives Considered | ||
|
||
|
@@ -446,7 +446,7 @@ The following sequence diagram shows how a show operation goes through the `Logi | |
|
||
The following activity diagram summarizes what happens when a user executes a new command: | ||
|
||
<puml src="diagrams/ShowCommandActivityDiagram.puml" width="250" /> | ||
<puml src="diagrams/ShowCommandActivityDiagram.puml" width="250" align="center"/> | ||
|
||
#### Design Considerations & Alternatives Considered | ||
|
||
|
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!