forked from nus-cs2103-AY2324S2/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagrams and dg feature for set weak #107
Merged
Wongqingyee
merged 3 commits into
AY2324S2-CS2103T-T09-1:master
from
yashma-sonara:update-DG
Mar 29, 2024
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
@startuml | ||
'https://plantuml.com/class-diagram | ||
|
||
hide circle | ||
hide methods | ||
|
||
skinparam ClassFontColor #000000 | ||
skinparam ClassBorderColor #000000 | ||
skinparam ClassBackgroundColor #FFFFAA | ||
|
||
title Before set weak Command | ||
|
||
package addressBook <<rectangle>> { | ||
class State0 as "<U>p0:Person</u>" { | ||
studentId = A2345678S | ||
grade = A+ | ||
} | ||
class State1 as "<u>p1:Person</u>" { | ||
studentId = A0123456X | ||
grade = C | ||
weak | ||
} | ||
class State2 as "<u>p2:Person</u>" { | ||
studentId = A1234567H | ||
grade = B+ | ||
} | ||
} | ||
|
||
State1 -[hidden]right-> State2 | ||
@enduml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
@startuml | ||
'https://plantuml.com/class-diagram | ||
|
||
hide circle | ||
hide methods | ||
|
||
skinparam ClassFontColor #000000 | ||
skinparam ClassBorderColor #000000 | ||
skinparam ClassBackgroundColor #FFFFAA | ||
|
||
title After set weak Command (set weak B+) | ||
|
||
package addressBook <<rectangle>> { | ||
class State0 as "<U>p0:Person</u>" { | ||
studentId = A2345678S | ||
grade = A+ | ||
} | ||
class State1 as "<u>p1:Person</u>" { | ||
studentId = A0123456X | ||
grade = C | ||
weak | ||
} | ||
class State2 as "<u>p2:Person</u>" { | ||
studentId = A1234567H | ||
grade = B+ | ||
weak | ||
} | ||
} | ||
|
||
State1 -[hidden]right-> State2 | ||
@enduml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
@startuml | ||
skin rose | ||
skinparam ActivityFontSize 15 | ||
skinparam ArrowFontSize 12 | ||
start | ||
:User executes set weak command; | ||
|
||
'Since the beta syntax does not support placing the condition outside the | ||
'diamond we place it as the true branch instead. | ||
|
||
:Parse grade from command; | ||
if () then ([Grade is valid]) | ||
:Update thresholdGrade value; | ||
else ([else]) | ||
:Display error message; | ||
endif | ||
stop | ||
@enduml |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure whether this is how weak should be shown. Because weak is not really an attribute of person class, rather its evaluated everytime. |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean "different" instead of "difference"?