Add diagrams and dg feature for set weak #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
============================================
+ Coverage 75.57% 75.99% +0.41%
- Complexity 479 489 +10
============================================
Files 78 78
Lines 1511 1533 +22
Branches 143 148 +5
============================================
+ Hits 1142 1165 +23
Misses 325 325
+ Partials 44 43 -1 ☔ View full report in Codecov by Sentry. |
yashma-sonara
commented
Mar 29, 2024
There was a problem hiding this comment.
I'm not sure whether this is how weak should be shown. Because weak is not really an attribute of person class, rather its evaluated everytime.
ronnnnnnnnn
reviewed
Mar 29, 2024
| By default, we have set C+ as the threshold, meaning that a student with grade lower than C+ is | ||
| displayed with a weak marker next to their name. | ||
|
|
||
| The command "set weak [grade]" followed by the grade allows the instructor to set a difference grade as the |
There was a problem hiding this comment.
Did you mean "different" instead of "difference"?
|
For studentId and grade should be separate objects. Can refer to the ModelClassDiagram. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.