Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve merge conflict in DeleteCommandParser #126

Merged

Conversation

cheahTJ
Copy link

@cheahTJ cheahTJ commented Apr 2, 2024

Linked to this #112, trying to resolve this merge conflict so that the code from change-edit-command can merge to master

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.98%. Comparing base (23c4a60) to head (c7b6547).
Report is 1 commits behind head on change-edit-command.

Files Patch % Lines
src/main/java/seedu/address/MainApp.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             change-edit-command     #126      +/-   ##
=========================================================
+ Coverage                  75.92%   75.98%   +0.06%     
- Complexity                   561      562       +1     
=========================================================
  Files                         84       84              
  Lines                       1815     1820       +5     
  Branches                     197      198       +1     
=========================================================
+ Hits                        1378     1383       +5     
  Misses                       370      370              
  Partials                      67       67              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ragnapop
Copy link

Ragnapop commented Apr 2, 2024

merge conflict seems to be able to be resolved with this commit.

@Ragnapop Ragnapop merged commit 00fd262 into AY2324S2-CS2103T-T15-2:change-edit-command Apr 2, 2024
5 checks passed
@cheahTJ cheahTJ self-assigned this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants