Merge pull request #365 from voondo/patch-1

Update boolean_filter : on/off support
AaronLasseigne · Jun 7, 2016 · 1c2b49e · 1c2b49e
2 parents 2ac54f7 + 10b6a47
commit 1c2b49e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/active_interaction/filters/boolean_filter.rb b/lib/active_interaction/filters/boolean_filter.rb
@@ -21,9 +21,9 @@ class BooleanFilter < Filter
 
     def cast(value, _interaction)
       case value
-      when FalseClass, '0', /\Afalse\z/i
+      when FalseClass, '0', /\Afalse\z/i, /\Aoff\z/i
         false
-      when TrueClass, '1', /\Atrue\z/i
+      when TrueClass, '1', /\Atrue\z/i, /\Aon\z/i
         true
       else
         super

diff --git a/spec/active_interaction/filters/boolean_filter_spec.rb b/spec/active_interaction/filters/boolean_filter_spec.rb
@@ -8,15 +8,15 @@
 
   describe '#cast' do
     context 'falsey' do
-      [false, '0', 'false', 'FALSE'].each do |value|
+      [false, '0', 'false', 'FALSE', 'off', 'OFF'].each do |value|
         it "returns false for #{value.inspect}" do
           expect(filter.cast(value, nil)).to be_falsey
         end
       end
     end
 
     context 'truthy' do
-      [true, '1', 'true', 'TRUE'].each do |value|
+      [true, '1', 'true', 'TRUE', 'on', 'ON'].each do |value|
         it "returns true for #{value.inspect}" do
           expect(filter.cast(value, nil)).to be_truthy
         end