Update boolean_filter : on/off support #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, thanks! What do you think about this, @AaronLasseigne? I think it's reasonable to support. |
|
It looks good to me. Should we merge the regexp together? |
|
Yeah, but we can do that after this is merged. We could also include the |
|
Thanks for the addition, @voondo! I'll release a new version shortly. On that note, what type of change (major or minor) do you think this is, @AaronLasseigne? I'm leaning toward minor. Also I combined the regexes in 436245a. |
|
I'd go minor. |
|
Released in version 3.2.0. |
|
thanks guys 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes used in other libraries (eg. polymer)