Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] add imagePullSecrets to pull the customImage from Private Registry #89

Closed
prasanna12510 opened this issue Feb 7, 2023 · 2 comments
Closed

[Feature request] add imagePullSecrets to pull the customImage from Private Registry #89

prasanna12510 opened this issue Feb 7, 2023 · 2 comments
Labels
Pending Feedback

Comments

@prasanna12510
Copy link

Is your feature request related to a problem? Please describe.
add support for imagePullSecrets to pull the customImage from Private Registry

Describe the solution you'd like
add imagePullSecrets with Image and ImagePullPolicy Similar to deployments
@AbdelrhmanHamouda
Copy link
Owner

Hello @prasanna12510 ,

Thank you for taking the time to report this enhancement. This is a nice addition to make the operator more feature complete. That being said, atm, this won't make it to the top of my priority list. However, I strongly invite you to open a PR with this contribution and i can review it and work together on it till it is added to the project.

I am assuming that you are looking for something similar to this: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/

jachinte added a commit to VarxenHQ/locust-k8s-operator that referenced this issue Mar 13, 2023
@jachinte
feat(AbdelrhmanHamouda#89): add support for pulling the Locust image …
6bf0eef 
…from private registries
@jachinte jachinte mentioned this issue Mar 13, 2023
Merged
jachinte added a commit to VarxenHQ/locust-k8s-operator that referenced this issue Mar 13, 2023
@jachinte
refactor(AbdelrhmanHamouda#89): rename resource attributes
f94e4e9
jachinte added a commit to VarxenHQ/locust-k8s-operator that referenced this issue Mar 13, 2023
@jachinte
feat(AbdelrhmanHamouda#89): add support for pulling the Locust image …
2ed7a23 
…from private registries

refactor(AbdelrhmanHamouda#89): rename resource attributes
jachinte added a commit to VarxenHQ/locust-k8s-operator that referenced this issue Mar 13, 2023
@jachinte
feat(AbdelrhmanHamouda#89): add support for pulling the Locust image …
5ca9d73 
…from private registries
jachinte added a commit to VarxenHQ/locust-k8s-operator that referenced this issue Apr 3, 2023
@jachinte
fix(AbdelrhmanHamouda#89): correct method name and delete unused impo…
3a544f3 
…rts (AbdelrhmanHamouda#98)
jachinte added a commit to VarxenHQ/locust-k8s-operator that referenced this issue Apr 3, 2023
@jachinte
docs(AbdelrhmanHamouda#89): update the image pull secrets/policy docu…
b04034b 
…mentation (AbdelrhmanHamouda#98)
jachinte added a commit to VarxenHQ/locust-k8s-operator that referenced this issue Apr 3, 2023
@jachinte
feat(AbdelrhmanHamouda#89): add support for pulling the Locust image …
7b257c4 
…from private registries (AbdelrhmanHamouda#98)
jachinte added a commit to VarxenHQ/locust-k8s-operator that referenced this issue Apr 3, 2023
@jachinte
feat(AbdelrhmanHamouda#89): add support for pulling the Locust image …
d3c554c 
…from private registries (AbdelrhmanHamouda#98)
jachinte added a commit to VarxenHQ/locust-k8s-operator that referenced this issue Apr 3, 2023
@jachinte
feat(AbdelrhmanHamouda#89): add support for pulling the Locust image …
59ed7b7 
…from private registries (AbdelrhmanHamouda#98)
AbdelrhmanHamouda pushed a commit that referenced this issue Apr 22, 2023
@jachinte
feat(#89): add support for pulling the Locust image from private regi…
9d7bfa4 
…stries (#98) by @jachinte
@AbdelrhmanHamouda
Copy link
Owner

solved with #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Pending Feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AbdelrhmanHamouda @prasanna12510