Patch @cosmjs/math for SES compatibility #9583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
5852855
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c5e93326.agoric-sdk.pages.dev |
| Branch Preview URL: | https://kriskowal-cosmjs-math-patch.agoric-sdk.pages.dev |
dckc
reviewed
Jun 26, 2024
| // A test to verify that importing @cosmsjs/math into an ESM via bundleSource | ||
| // can see the exported Decimal constructor, which was at time of writing obscured | ||
| // by https://github.com/endojs/endo/pull/2330, temporarily mitigated by a patch. | ||
| // Placed here only because Agoric CLI depends on both bundleSource and CosmJS math. |
There was a problem hiding this comment.
seems like it should go in cosmic-proto.
There was a problem hiding this comment.
Looks like it was copied rather than moved.
I trust you'll get rid of the copy in agoric-cli before merging.
There was a problem hiding this comment.
Thank you for spotting. This wasn’t obvious locally.
kriskowal
force-pushed
the
kriskowal-cosmjs-math-patch-9408
branch
from
d697b4f to
e985d4f
Compare
kriskowal
force-pushed
the
kriskowal-cosmjs-math-patch-9408
branch
from
e985d4f to
0fdf898
Compare
dckc
approved these changes
Jun 27, 2024
| // A test to verify that importing @cosmsjs/math into an ESM via bundleSource | ||
| // can see the exported Decimal constructor, which was at time of writing obscured | ||
| // by https://github.com/endojs/endo/pull/2330, temporarily mitigated by a patch. | ||
| // Placed here only because Agoric CLI depends on both bundleSource and CosmJS math. |
There was a problem hiding this comment.
Looks like it was copied rather than moved.
I trust you'll get rid of the copy in agoric-cli before merging.
kriskowal
force-pushed
the
kriskowal-cosmjs-math-patch-9408
branch
from
0fdf898 to
6acdcef
Compare
kriskowal
force-pushed
the
kriskowal-cosmjs-math-patch-9408
branch
from
6acdcef to
5852855
Compare
kriskowal
added
force:integration
|
How does this address the original issue. A patch in agoric-sdk won't affect dapps if the dapp uses packages installed from NPM |
The fix for the underlying issue is endojs/endo#2330 |
mergify bot
added a commit
that referenced
this pull request
Jul 12, 2024
refs: #9408 ## Description cosmjs deps add a lot of size and complicates our builds (#9583) At runtime we only need `Decimal` so this vendors that (just the subset necessary) and drops all other runtime deps. ### Security Considerations less supply chain ### Scaling Considerations none ### Documentation Considerations Maybe get this upstream to reduce maintenance. ### Testing Considerations CI suffices? ### Upgrade Considerations None, not on chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9408
Description
Pending endojs/endo#2330, we patch
@cosmjs/mathsuch that imports from ESM reflect the exported types.Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
Included test.
Upgrade Considerations
None.