Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch @cosmjs/math for SES compatibility #9583

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Patch @cosmjs/math for SES compatibility #9583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f026ff3
fix: Patch @cosmjs/[email protected] pending Endo fix
kriskowal Jun 26, 2024
5852855
test: Verify patch for @cosmjs/math
kriskowal Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/cosmic-proto/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@
"@agoric/cosmos": "^0.34.1",
"@ava/typescript": "^4.1.0",
"@cosmology/telescope": "^1.7.1",
"@endo/bundle-source": "^3.2.3",
"@endo/import-bundle": "^1.1.2",
"ava": "^5.3.1",
"rimraf": "^5.0.0",
"tsd": "^0.30.7",
Expand Down
1 change: 1 addition & 0 deletions packages/cosmic-proto/test/bundle-cosmjs-math.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { Decimal } from '@cosmjs/math';
18 changes: 18 additions & 0 deletions packages/cosmic-proto/test/bundle-cosmjs-math.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// A test to verify that importing @cosmsjs/math into an ESM via bundleSource
// can see the exported Decimal constructor, which was at time of writing obscured
// by https://github.com/endojs/endo/pull/2330, temporarily mitigated by a patch.
// Placed here only because Agoric CLI depends on both bundleSource and CosmJS math.

import test from '@endo/ses-ava/prepare-endo.js';
import url from 'url';
import bundleSource from '@endo/bundle-source';
import { importBundle } from '@endo/import-bundle';

test('bundled @comjs/math exports Decimal', async t => {
const entryPath = url.fileURLToPath(
new URL('bundle-cosmjs-math.js', import.meta.url),
);
const bundle = await bundleSource(entryPath);
const ns = await importBundle(bundle);
t.not(ns.Decimal, undefined);
});
25 changes: 25 additions & 0 deletions patches/@cosmjs+math+0.32.3.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
diff --git a/node_modules/@cosmjs/math/build/index.js b/node_modules/@cosmjs/math/build/index.js
index 1f812f6..6e25ac9 100644
--- a/node_modules/@cosmjs/math/build/index.js
+++ b/node_modules/@cosmjs/math/build/index.js
@@ -1,11 +1,10 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.Uint64 = exports.Uint53 = exports.Uint32 = exports.Int53 = exports.Decimal = void 0;
-var decimal_1 = require("./decimal");
-Object.defineProperty(exports, "Decimal", { enumerable: true, get: function () { return decimal_1.Decimal; } });
-var integers_1 = require("./integers");
-Object.defineProperty(exports, "Int53", { enumerable: true, get: function () { return integers_1.Int53; } });
-Object.defineProperty(exports, "Uint32", { enumerable: true, get: function () { return integers_1.Uint32; } });
-Object.defineProperty(exports, "Uint53", { enumerable: true, get: function () { return integers_1.Uint53; } });
-Object.defineProperty(exports, "Uint64", { enumerable: true, get: function () { return integers_1.Uint64; } });
+'use strict';
+Object.defineProperty(exports, '__esModule', { value: true });
+var decimal_1 = require('./decimal');
+var integers_1 = require('./integers');
+exports.Uint64 = integers_1.Uint64;
+exports.Uint53 = integers_1.Uint53;
+exports.Uint32 = integers_1.Uint32;
+exports.Int53 = integers_1.Int53;
+exports.Decimal = decimal_1.Decimal;
//# sourceMappingURL=index.js.map
Loading