-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AURO-MIGRATION: Update dependencies to support latest node version(s) #78
AURO-MIGRATION: Update dependencies to support latest node version(s) #78
Conversation
BREAKING CHANGE: last change was breaking _on a patch version_ because of peer dependencies Summary: Our current build process relies on peer dependencies being present, but the peer dependency pipeline is causing far more issues than it's worth. Why not just make them regular dependencies? This is what this PR does :)
Reviewer's Guide by SourceryThis pull request updates the project's dependencies to ensure compatibility with newer Node.js versions. It includes updates to auro-header, auro-library, webcorestylesheets, design-tokens, and eslint-config. Additionally, the CDN links in the README have been updated to reflect the new design-tokens location. Updated class diagram for package.json dependenciesclassDiagram
class packageJson {
-dependencies
-devDependencies
-peerDependencies
+updateDependencies()
+updateDevDependencies()
+updatePeerDependencies()
}
note for packageJson "Dependencies updated to support latest node version(s)"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DukeFerdinand - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like you're updating dependencies, make sure to run
npm audit
andnpm update
to ensure there are no security vulnerabilities. - Consider adding a comment to the code explaining why these dependency updates are necessary.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@aurodesignsystem/design-tokens@/dist/auro-classic/CSSCustomProperties.css" /> | ||
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@aurodesignsystem/webcorestylesheets@/dist/bundled/essentials.css" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (bug_risk): Missing version numbers in URLs for design tokens and web core stylesheets.
The updated URLs for the design tokens and web core stylesheets are missing version numbers. While using the latest version might be intentional, it could lead to unexpected behavior if new versions introduce breaking changes. Please clarify the intent behind removing the version numbers and ensure this is the desired behavior.
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves AlaskaAirlines/auro-cli#37 by updating eslint config to latest version (uses node >=18 for LTS support).
Summary by Sourcery
Updates dependencies to support the latest Node versions and align with the latest Auro Design System packages. This includes updates to eslint configuration, design tokens, webcorestylesheets, and other related packages.
Build:
Chores: