-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auro-button: Updating to 6.3.3 breaks headless chrome tests #127
Comments
I think I know what the issue is here. For now, it seems like you can work around it by installing the following commands (I tested this with the hangar locally):
After that, I was able to successfully run the Headless Chrome tests. |
The root cause is an update to the button's dependencies that required a higher version of lit-html than was installed in the component hangar. There were then 2 versions of lit-html, resulting in the broken button you saw above. See da4edec I think we can fix this by lowering the required version of lit-html. @blackfalcon I'll be submitting a PR shortly. |
Sweet, thank you @geoffrich! I'll use that for now. Once auro-button is updated I'll update to the newer version with the fix. |
## [6.3.4](v6.3.3...v6.3.4) (2021-06-23) ### Bug Fixes * allow wider range of lit-html versions [#127](#127) ([7ec7463](7ec7463))
🎉 This issue has been resolved in version 6.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I confirmed that the new version fixes the Component Hangar tests on my local box. |
Describe the bug
I tried updating from 6.2.0 to 6.3.3, but this broke the headless chrome integration tests. Nothing else was changed
I would not expect all those tests to break simply by updating the version for auro-button.
The tests still work when updating to 6.3.2, so it seems to be something specifically with the 6.3.3 release. I'm unsure if there's another change that I'm supposed to be making in Component Hanger, or a dependency I'm missing.
To Reproduce
Here is the pipeline with the tests failing: Component Hanger Build
I don't think there's an easy way to reproduce it with just auro-button. The easiest way is to set up Component Hanger repository and run the tests locally.
The text was updated successfully, but these errors were encountered: