Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-button: Updating to 6.3.3 breaks headless chrome tests #127

Closed
diana-wang opened this issue Jun 22, 2021 · 5 comments · Fixed by #128
Closed

auro-button: Updating to 6.3.3 breaks headless chrome tests #127

diana-wang opened this issue Jun 22, 2021 · 5 comments · Fixed by #128
Assignees
Labels
released Completed work has been released Type: Bug Bug or Bug fixes

Comments

@diana-wang
Copy link

Describe the bug

I tried updating from 6.2.0 to 6.3.3, but this broke the headless chrome integration tests. Nothing else was changed
image

I would not expect all those tests to break simply by updating the version for auro-button.

The tests still work when updating to 6.3.2, so it seems to be something specifically with the 6.3.3 release. I'm unsure if there's another change that I'm supposed to be making in Component Hanger, or a dependency I'm missing.

To Reproduce

Here is the pipeline with the tests failing: Component Hanger Build

I don't think there's an easy way to reproduce it with just auro-button. The easiest way is to set up Component Hanger repository and run the tests locally.

@diana-wang diana-wang added the Type: Bug Bug or Bug fixes label Jun 22, 2021
@geoffrich
Copy link
Contributor

I think I know what the issue is here. For now, it seems like you can work around it by installing the following commands (I tested this with the hangar locally):

npm i lit-element@latest
npm i lit-html@latest
npm dedupe

After that, I was able to successfully run the Headless Chrome tests.

@geoffrich geoffrich self-assigned this Jun 22, 2021
@geoffrich
Copy link
Contributor

The root cause is an update to the button's dependencies that required a higher version of lit-html than was installed in the component hangar. There were then 2 versions of lit-html, resulting in the broken button you saw above. See da4edec

I think we can fix this by lowering the required version of lit-html. @blackfalcon I'll be submitting a PR shortly.

@diana-wang
Copy link
Author

Sweet, thank you @geoffrich! I'll use that for now. Once auro-button is updated I'll update to the newer version with the fix.

@AuroDesignSystem
Copy link
Collaborator

🎉 This issue has been resolved in version 6.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AuroDesignSystem AuroDesignSystem added the released Completed work has been released label Jun 23, 2021
@geoffrich
Copy link
Contributor

I confirmed that the new version fixes the Component Hangar tests on my local box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants