fix: allow wider range of lit-html versions #127 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffrich
added
the
Status: Review Needed
blackfalcon
added
Type: Bug
blackfalcon
approved these changes
Jun 23, 2021
|
🎉 This PR is included in version 6.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Fixes #127
Summary:
da4edec added lit-html as a direct dependency to fix a separate issue. However, the version range was too restrictive, allowing for the possibility that multiple lit-html versions could be installed at once. When this happens, the component breaks.
This PR attempts to fix the issue by being very permissive as to the version of lit-html installed, as recommended in the lit docs. I had to edit the package.json manually because running
npm i lit-html@^1.0.0put the latest version in the package.json.I'm not 100% sure this will fix it, but I'm pretty sure.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team