Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spacing between icon and text in button #164

Closed
leeejune opened this issue Jul 18, 2022 · 0 comments · Fixed by #168
Closed

Add spacing between icon and text in button #164

leeejune opened this issue Jul 18, 2022 · 0 comments · Fixed by #168
Assignees
@blackfalcon @leeejune
Labels
auro-button Status: Work In Progress Issue or Pull Request work is in Progress Type: Design New or related Design work
Milestone
auro-button v6.4-rc

Comments

@leeejune
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The icon and text in the button is too close to each other.

Describe the solution you'd like

Add 4px spacing between the icon and text.

The image below shows the current button (left) and the proposed button (right).
@leeejune leeejune added Type: Design New or related Design work not-reviewed Issue has not been reviewed by Auro team members labels Jul 18, 2022
leeejune added a commit that referenced this issue Aug 3, 2022
@leeejune
feat: add spacing between icon and text #164
3d8be81
@braven112 braven112 removed the not-reviewed Issue has not been reviewed by Auro team members label Aug 5, 2022
@braven112 braven112 added this to the auro-button v6.4-rc milestone Aug 5, 2022
@leeejune leeejune mentioned this issue Aug 17, 2022
Closed
6 tasks
@leeejune leeejune linked a pull request Aug 17, 2022 that will close this issue
feat: add spacing between icon and text #164 #169
Closed
6 tasks
blackfalcon pushed a commit that referenced this issue Aug 23, 2022
@leeejune @blackfalcon
feat: add spacing between icon and text #164
942229e
blackfalcon added a commit that referenced this issue Aug 25, 2022
@blackfalcon
fix(inline): update to better center content within button #164
ffd3478 
Changes to be committed:
modified:   src/style.scss
@blackfalcon blackfalcon linked a pull request Aug 25, 2022 that will close this issue
feat: add slim padding #168
Merged
6 tasks
@blackfalcon blackfalcon mentioned this issue Aug 25, 2022
Merged
6 tasks
@blackfalcon blackfalcon added auro-button Status: Work In Progress Issue or Pull Request work is in Progress Priority: High and removed Priority: High labels Sep 2, 2022
@blackfalcon blackfalcon self-assigned this Sep 7, 2022
blackfalcon added a commit that referenced this issue Sep 13, 2022
@blackfalcon
fix(inline): update to better center content within button #164
0f536e0 
Changes to be committed:
modified:   src/style.scss
blackfalcon added a commit that referenced this issue Sep 14, 2022
@blackfalcon
fix(inline): update to better center content within button #164
4335b6d 
Changes to be committed:
modified:   src/style.scss
AuroDesignSystem pushed a commit that referenced this issue Sep 14, 2022
@semantic-release-bot
chore(release): 6.4.0 [skip ci]
4050bb8 
# [6.4.0](v6.3.8...v6.4.0) (2022-09-14)

### Bug Fixes

* **inline:** update to better center content within button [#164](#164) ([4335b6d](4335b6d))

### Features

* **css:** update tertiary background color ([615d5d6](615d5d6))
* **slim:** add new feature attribute [#159](#159) ([ef661ac](ef661ac))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

@leeejune leeejune

Labels
auro-button Status: Work In Progress Issue or Pull Request work is in Progress Type: Design New or related Design work
Projects
None yet
Milestone
auro-button v6.4-rc
3 participants
@blackfalcon @braven112 @leeejune