feat: add spacing between icon and text #164 #169
Conversation
| display: flex; | ||
| flex-direction: row; | ||
| align-items: center; | ||
| justify-content: center; | ||
| gap: var(--auro-size-xxs); |
There was a problem hiding this comment.
By making this selector display:flex the element now appears as a block element. Buttons by default are inline-block elements. I do not see changing the display type of an element as a reasonable outcome for gaining space between text and an icon used as content.
You can create a selector that will target auro-icon directly and add a margin as needed. This will not have a negative effect on the display type of the element.
Also, I would argue that this is not a feature add, but a bug correction. Please update feat to fix in the commit message.
There was a problem hiding this comment.
FYI... it is super helpful, especially with visual changes to have a before and after screenshot for reference when reviewing the PR.
This also applied to the issues themselves. Giving the reviewer visual context of the pending change is super helpful.
There was a problem hiding this comment.
The downside to the margin approach is the we have to know whether the icon is to the left or right of the text.
That's a good call out on the inline-block thing. Would inline-flex behave similar to inline-block?
blackfalcon
force-pushed
the
junelee/addSpacing/#164
branch
from
3d8be81 to
942229e
Compare
|
Moved work to #168 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #164
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Added xxs spacing between text and icon. Also applied flex-box to use the
gapattribute.Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team