Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-button-light: Missing conditional check before defining custom element #95

Closed
littleninja opened this issue Jan 22, 2021 · 1 comment · Fixed by #96
Closed

auro-button-light: Missing conditional check before defining custom element #95

littleninja opened this issue Jan 22, 2021 · 1 comment · Fixed by #96
Assignees
@blackfalcon
Labels
released Completed work has been released Status: Review Needed Work is completed, user is requesting feedback Type: Bug Bug or Bug fixes

Comments

@littleninja
Copy link

Describe the bug

auro-button has a conditional check, it prevents the custom element registry from throwing an error by trying to define the same custom element twice. This check is missing from auro-button light.

To Reproduce

Steps to reproduce the behavior:

  1. Create two projects, a component and an app
  2. App loads component
  3. Both app and component use auro-button-light
    Outcome: error in the browser console, auro-button-light is already defined.

Expected behavior

First to load auro-button-light defines the element (app or component), second skips the define step.

Screenshots

n/a

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

In discussion, is there a question whether we still need auro-button-light given the enhancements with es5 bundling and eventually dropping IE11 support?
@littleninja littleninja added the Type: Bug Bug or Bug fixes label Jan 22, 2021
@blackfalcon blackfalcon added the Status: Review Needed Work is completed, user is requesting feedback label Jan 23, 2021
blackfalcon added a commit that referenced this issue Jan 23, 2021
@blackfalcon
fix: #95 Missing conditional check
0d6f0a6
@blackfalcon blackfalcon mentioned this issue Jan 23, 2021
Merged
6 tasks
blackfalcon added a commit that referenced this issue Jan 30, 2021
@blackfalcon
fix: #95 Missing conditional check
2fb749d
AuroDesignSystem pushed a commit that referenced this issue Jan 30, 2021
@semantic-release-bot
chore(release): 6.0.1 [skip ci]
6732e84 
## [6.0.1](v6.0.0...v6.0.1) (2021-01-30)

### Bug Fixes

* [#95](#95) Missing conditional check ([2fb749d](2fb749d))
@AuroDesignSystem
Copy link
Collaborator

🎉 This issue has been resolved in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AuroDesignSystem AuroDesignSystem added the released Completed work has been released label Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
released Completed work has been released Status: Review Needed Work is completed, user is requesting feedback Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix element registration AlaskaAirlines/auro-button
3 participants
@blackfalcon @littleninja @AuroDesignSystem