Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix element registration #96

Merged
merged 5 commits into from
Jan 30, 2021
Merged

Fix element registration #96

merged 5 commits into from
Jan 30, 2021

Conversation

blackfalcon
Copy link
Member

@blackfalcon blackfalcon commented Jan 23, 2021

Alaska Airlines Pull Request

This PR addresses one bug and updates doc/demo support to use markdown format.

Fixes: #95

Summary:

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Fix bug

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@blackfalcon blackfalcon added Type: Bug Bug or Bug fixes Type: Refactoring A code change that neither fixes a bug nor adds a feature labels Jan 23, 2021
@blackfalcon blackfalcon self-assigned this Jan 23, 2021
Copy link

@littleninja littleninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m aware of changes with Rollup and demo docs but I’m not sure I’m familiar enough to approve.

Copy link
Contributor

@geoffrich geoffrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise changes look good.

demo/index_old.html Outdated Show resolved Hide resolved
@blackfalcon blackfalcon force-pushed the fixElementRegistration branch from 48f339a to 3a39f2f Compare January 30, 2021 00:54
@blackfalcon blackfalcon merged commit c65d38c into master Jan 30, 2021
@blackfalcon blackfalcon deleted the fixElementRegistration branch January 30, 2021 00:58
@AuroDesignSystem
Copy link
Collaborator

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AuroDesignSystem AuroDesignSystem added the released Completed work has been released label Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released Type: Bug Bug or Bug fixes Type: Refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auro-button: general updates auro-button-light: Missing conditional check before defining custom element
4 participants