Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme support #64

Closed
2 tasks
jason-capsule42 opened this issue Jul 18, 2024 · 1 comment · Fixed by #65, #68 or #72
Closed
2 tasks

Theme support #64

jason-capsule42 opened this issue Jul 18, 2024 · 1 comment · Fixed by #65, #68 or #72
Assignees
@jordanjones243
Labels
auro-card

Comments

@jason-capsule42
Copy link
Member

jason-capsule42 commented Jul 18, 2024 •
edited by jordanjones243
Loading

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Rules and tokens to be edited can be found in the comments.

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jason-capsule42 jason-capsule42 added Type: Feature New Feature auro-card not-reviewed Issue has not been reviewed by Auro team members labels Jul 18, 2024
@jason-capsule42 jason-capsule42 self-assigned this Jul 18, 2024
jason-capsule42 added a commit that referenced this issue Jul 18, 2024
@jason-capsule42
feat(themes): support component themes #64
f08bd92
@jason-capsule42 jason-capsule42 mentioned this issue Jul 18, 2024
Merged
6 tasks
@jason-capsule42 jason-capsule42 linked a pull request Jul 18, 2024 that will close this issue
feat(themes): support component themes #64 #65
Merged
6 tasks
jason-capsule42 added a commit that referenced this issue Jul 18, 2024
@jason-capsule42
feat(themes): support component themes #64
fcd9c4f
blackfalcon pushed a commit that referenced this issue Jul 18, 2024
@semantic-release-bot
chore(release): 3.1.0-beta.1 [skip ci]
edeb70a 
# [3.1.0-beta.1](v3.0.0...v3.1.0-beta.1) (2024-07-18)

### Features

* **themes:** support component themes [#64](#64) ([fcd9c4f](fcd9c4f))

### Performance Improvements

* add messaging script back in ([3ce103b](3ce103b))
* update commit message path ([46e689c](46e689c))
* Update pre-commit hook and husky prepare command. ([6213ee2](6213ee2))
@jordanjones243 jordanjones243 linked a pull request Aug 14, 2024 that will close this issue
Move theme support from Beta to Main #68
Merged
6 tasks
@jordanjones243 jordanjones243 mentioned this issue Aug 14, 2024
Merged
6 tasks
jordanjones243 added a commit that referenced this issue Sep 17, 2024
@jordanjones243
perf(theming): resolve minor color theming bugs #64
71d1da6
@jordanjones243
Copy link
Contributor

jordanjones243 commented Sep 18, 2024 •
edited
Loading

Ticket is blocked until auro-hyperlink's theming support is complete:

@jason-capsule42 jason-capsule42 removed the not-reviewed Issue has not been reviewed by Auro team members label Sep 30, 2024
jordanjones243 added a commit that referenced this issue Oct 1, 2024
@jordanjones243
perf: update dependencies and lint configuration
ca5a300 
BREAKING CHANGE: trigger major release for color theme support #64
@jordanjones243 jordanjones243 mentioned this issue Oct 1, 2024
Merged
6 tasks
@jordanjones243 jordanjones243 linked a pull request Oct 1, 2024 that will close this issue
Beta tech debt #72
Merged
6 tasks
jordanjones243 added a commit that referenced this issue Oct 1, 2024
@jordanjones243
perf: update dependencies and lint configuration
7bf221f 
BREAKING CHANGE: trigger major release for color theme support #64
blackfalcon pushed a commit that referenced this issue Oct 1, 2024
@semantic-release-bot
chore(release): 4.0.0-beta.1 [skip ci]
2c24e96 
# [4.0.0-beta.1](v3.1.0-beta.1...v4.0.0-beta.1) (2024-10-01)

### Features

* add tag name as attribute when custom registered ([847e67f](847e67f))

### Performance Improvements

* **label:** remove github label colors ([62f7c1d](62f7c1d))
* refactor custom component registration config ([87acf80](87acf80))
* update dependencies and lint configuration ([7bf221f](7bf221f))
* use custom registered version of hyperlink [#70](#70) ([5208525](5208525))

### BREAKING CHANGES

* trigger major release for color theme support #64
jason-capsule42 added a commit that referenced this issue Oct 1, 2024
@jason-capsule42
feat(themes): support component themes #64
c639330
jason-capsule42 pushed a commit that referenced this issue Oct 1, 2024
@semantic-release-bot @jason-capsule42
chore(release): 3.1.0-beta.1 [skip ci]
f2d9ee4 
# [3.1.0-beta.1](v3.0.0...v3.1.0-beta.1) (2024-07-18)

### Features

* **themes:** support component themes [#64](#64) ([fcd9c4f](fcd9c4f))

### Performance Improvements

* add messaging script back in ([3ce103b](3ce103b))
* update commit message path ([46e689c](46e689c))
* Update pre-commit hook and husky prepare command. ([6213ee2](6213ee2))
jason-capsule42 pushed a commit that referenced this issue Oct 1, 2024
@jordanjones243 @jason-capsule42
perf: update dependencies and lint configuration
0fe766b 
BREAKING CHANGE: trigger major release for color theme support #64
jason-capsule42 pushed a commit that referenced this issue Oct 1, 2024
@semantic-release-bot @jason-capsule42
chore(release): 4.0.0-beta.1 [skip ci]
cad3452 
# [4.0.0-beta.1](v3.1.0-beta.1...v4.0.0-beta.1) (2024-10-01)

### Features

* add tag name as attribute when custom registered ([847e67f](847e67f))

### Performance Improvements

* **label:** remove github label colors ([62f7c1d](62f7c1d))
* refactor custom component registration config ([87acf80](87acf80))
* update dependencies and lint configuration ([7bf221f](7bf221f))
* use custom registered version of hyperlink [#70](#70) ([5208525](5208525))

### BREAKING CHANGES

* trigger major release for color theme support #64
blackfalcon pushed a commit that referenced this issue Oct 1, 2024
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
04e44b8 
# [4.0.0](v3.0.0...v4.0.0) (2024-10-01)

### Features

* add tag name as attribute when custom registered ([fd68035](fd68035))
* **themes:** support component themes [#64](#64) ([c639330](c639330))

### Performance Improvements

* add messaging script back in ([bd35040](bd35040))
* **label:** remove github label colors ([0cd5590](0cd5590))
* refactor custom component registration config ([5663e82](5663e82))
* update commit message path ([acb4a09](acb4a09))
* update dependencies and lint configuration ([0fe766b](0fe766b))
* Update pre-commit hook and husky prepare command. ([7ed75e2](7ed75e2))
* use custom registered version of hyperlink [#70](#70) ([59df951](59df951))

### BREAKING CHANGES

* trigger major release for color theme support #64
@jason-capsule42 jason-capsule42 removed the Type: Feature New Feature label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-card
Projects
None yet
Milestone
No milestone
3 participants
@jason-capsule42 @jordanjones243 @Patrick-Daly-AA