Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color tokens for theming support #206

Closed
2 tasks
jordanjones243 opened this issue Mar 13, 2024 · 4 comments · Fixed by #238, #256 or #257
Closed
2 tasks

Update color tokens for theming support #206

jordanjones243 opened this issue Mar 13, 2024 · 4 comments · Fixed by #238, #256 or #257
Assignees
Labels
Type: Feature New Feature

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Mar 13, 2024

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Rules and tokens to be edited can be found in the comments.

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jordanjones243 jordanjones243 added not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature labels Mar 13, 2024
@jordanjones243
Copy link
Contributor Author

  • Hardcoded
    • Accent icon transition: transition: all .3s cubic-bezier(.215, .61, .355, 1);
    • Transparent
    • Solid (border type)
    • f0f0f0

@jason-capsule42 jason-capsule42 linked a pull request Jun 26, 2024 that will close this issue
6 tasks
@jordanjones243 jordanjones243 removed the not-reviewed Issue has not been reviewed by Auro team members label Aug 2, 2024
blackfalcon pushed a commit that referenced this issue Aug 19, 2024
# [2.8.0-beta.1](v2.7.1...v2.8.0-beta.1) (2024-08-19)

### Features

* implement tier 3 color tokens [#206](#206) ([563b498](563b498))

### Performance Improvements

* **deps:** update dependencies to latest versions ([43d7b62](43d7b62))
* use custom versioned auro-popover ([8e572f4](8e572f4))
@jordanjones243
Copy link
Contributor Author

Blocked until all color theming support is released for dependent components.

@jordanjones243
Copy link
Contributor Author

Need design to revise the semantic tokens being used within the tokens.scss file.

@jordanjones243
Copy link
Contributor Author

@leeejune Needs full design review.

jordanjones243 added a commit that referenced this issue Oct 3, 2024
BREAKING CHANGE: trigger major release for color theme support #206
@jordanjones243 jordanjones243 linked a pull request Oct 3, 2024 that will close this issue
6 tasks
blackfalcon pushed a commit that referenced this issue Oct 3, 2024
# [2.8.0-beta.2](v2.8.0-beta.1...v2.8.0-beta.2) (2024-10-03)

### Bug Fixes

* resolve minor color theming issues [#206](#206) ([0e705de](0e705de))

### Performance Improvements

* refactor custom component registration config ([910cac2](910cac2))
* update dependencies and file extensions ([06d116a](06d116a))
@jordanjones243 jordanjones243 mentioned this issue Oct 3, 2024
6 tasks
@jordanjones243 jordanjones243 linked a pull request Oct 3, 2024 that will close this issue
6 tasks
jordanjones243 added a commit that referenced this issue Oct 4, 2024
BREAKING CHANGE: trigger major release for color theme support #206
jordanjones243 added a commit that referenced this issue Oct 4, 2024
BREAKING CHANGE: trigger major release for color theme support #206
blackfalcon pushed a commit that referenced this issue Oct 4, 2024
# [3.0.0-beta.1](v2.8.0-beta.2...v3.0.0-beta.1) (2024-10-04)

### Performance Improvements

* **label:** remove github label colors ([7a933f2](7a933f2))

### BREAKING CHANGES

* **label:** trigger major release for color theme support #206
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
# [2.8.0-beta.1](v2.7.1...v2.8.0-beta.1) (2024-08-19)

### Features

* implement tier 3 color tokens [#206](#206) ([563b498](563b498))

### Performance Improvements

* **deps:** update dependencies to latest versions ([43d7b62](43d7b62))
* use custom versioned auro-popover ([8e572f4](8e572f4))
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
# [2.8.0-beta.2](v2.8.0-beta.1...v2.8.0-beta.2) (2024-10-03)

### Bug Fixes

* resolve minor color theming issues [#206](#206) ([0e705de](0e705de))

### Performance Improvements

* refactor custom component registration config ([910cac2](910cac2))
* update dependencies and file extensions ([06d116a](06d116a))
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
BREAKING CHANGE: trigger major release for color theme support #206
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
# [3.0.0-beta.1](v2.8.0-beta.2...v3.0.0-beta.1) (2024-10-04)

### Performance Improvements

* **label:** remove github label colors ([7a933f2](7a933f2))

### BREAKING CHANGES

* **label:** trigger major release for color theme support #206
blackfalcon pushed a commit that referenced this issue Oct 4, 2024
# [3.0.0](v2.7.1...v3.0.0) (2024-10-04)

### Bug Fixes

* resolve minor color theming issues [#206](#206) ([295cde2](295cde2))

### Features

* implement tier 3 color tokens [#206](#206) ([ba61cb0](ba61cb0))

### Performance Improvements

* **deps:** update dependencies to latest versions ([3b7de9a](3b7de9a))
* **label:** remove github label colors ([6114671](6114671))
* refactor custom component registration config ([79a9b77](79a9b77))
* update dependencies and file extensions ([47de0b3](47de0b3))
* use custom versioned auro-popover ([ea55bb3](ea55bb3))

### BREAKING CHANGES

* **label:** trigger major release for color theme support #206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
3 participants