-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta #257
Beta #257
Conversation
This commit also updates code to comply with linter requirement updates from latest esLint version. Additionally, build scripts were updated to be more concise and usable during active development.
# [2.8.0-beta.2](v2.8.0-beta.1...v2.8.0-beta.2) (2024-10-03) ### Bug Fixes * resolve minor color theming issues [#206](#206) ([0e705de](0e705de)) ### Performance Improvements * refactor custom component registration config ([910cac2](910cac2)) * update dependencies and file extensions ([06d116a](06d116a))
Reviewer's Guide by SourceryThis pull request implements several changes to the auro-datepicker component, focusing on theming support, color customization, and code refactoring. The changes include the addition of new CSS files for color management, updates to existing SCSS files, and modifications to JavaScript files to support the new theming system. Class diagram for AuroCalendarCell and AuroDatePickerclassDiagram
class AuroCalendarCell {
+String dateStr
+Boolean renderForDateSlot
+AuroLibraryRuntimeUtils runtimeUtils
+String popoverTag
+void handleTap()
+void updatePopoverSlotContent()
+void connectedCallback()
+Html render()
}
class AuroDatePicker {
+void generateRandomString(int length)
}
AuroCalendarCell --> AuroDatePicker
AuroCalendarCell --> AuroPopover
AuroCalendarCell --> AuroLibraryRuntimeUtils
AuroDatePicker --> AuroCalendarCell
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The refactoring of color-related styles into separate files is a good improvement for maintainability. Consider documenting the purpose of each new color file in a comment at the top of the file.
- The addition of theme support using CSS custom properties is excellent. It might be helpful to provide a brief guide or example in the documentation on how to use these new theming capabilities.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Surge demo deployment failed! 😭 |
BREAKING CHANGE: trigger major release for color theme support #206
# [3.0.0-beta.1](v2.8.0-beta.2...v3.0.0-beta.1) (2024-10-04) ### Performance Improvements * **label:** remove github label colors ([7a933f2](7a933f2)) ### BREAKING CHANGES * **label:** trigger major release for color theme support #206
🎉 This PR is included in version 3.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #180, #206
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Enhance the component with theme support using design tokens, fix color theming issues, and refactor component registration for better performance. Update dependencies and documentation to reflect these changes, and remove outdated scripts.
New Features:
Bug Fixes:
Enhancements:
Build:
Documentation:
Chores: