Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta #257

Merged
merged 15 commits into from
Oct 4, 2024
Merged

Beta #257

merged 15 commits into from
Oct 4, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Oct 3, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #180, #206

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Enhance the component with theme support using design tokens, fix color theming issues, and refactor component registration for better performance. Update dependencies and documentation to reflect these changes, and remove outdated scripts.

New Features:

  • Introduce theme support for the component, allowing it to be restyled using design tokens.

Bug Fixes:

  • Resolve minor color theming issues to ensure consistent appearance across components.

Enhancements:

  • Refactor custom component registration to use a new utility for versioned component tags.
  • Update dependencies and file extensions to improve performance and maintainability.

Build:

  • Add a new ESLint configuration file to standardize code quality checks.

Documentation:

  • Update documentation to include new theme support and usage examples with updated design tokens.

Chores:

  • Remove obsolete scripts and update changelog with recent changes.

jordanjones243 and others added 11 commits August 18, 2024 17:54
This commit also updates code to comply with linter requirement updates from latest esLint version. Additionally, build scripts were updated to be more concise and usable during active development.
# [2.8.0-beta.1](v2.7.1...v2.8.0-beta.1) (2024-08-19)

### Features

* implement tier 3 color tokens [#206](#206) ([563b498](563b498))

### Performance Improvements

* **deps:** update dependencies to latest versions ([43d7b62](43d7b62))
* use custom versioned auro-popover ([8e572f4](8e572f4))
# [2.8.0-beta.2](v2.8.0-beta.1...v2.8.0-beta.2) (2024-10-03)

### Bug Fixes

* resolve minor color theming issues [#206](#206) ([0e705de](0e705de))

### Performance Improvements

* refactor custom component registration config ([910cac2](910cac2))
* update dependencies and file extensions ([06d116a](06d116a))
@jordanjones243 jordanjones243 self-assigned this Oct 3, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner October 3, 2024 21:24
Copy link

sourcery-ai bot commented Oct 3, 2024

Reviewer's Guide by Sourcery

This pull request implements several changes to the auro-datepicker component, focusing on theming support, color customization, and code refactoring. The changes include the addition of new CSS files for color management, updates to existing SCSS files, and modifications to JavaScript files to support the new theming system.

Class diagram for AuroCalendarCell and AuroDatePicker

classDiagram
    class AuroCalendarCell {
        +String dateStr
        +Boolean renderForDateSlot
        +AuroLibraryRuntimeUtils runtimeUtils
        +String popoverTag
        +void handleTap()
        +void updatePopoverSlotContent()
        +void connectedCallback()
        +Html render()
    }
    class AuroDatePicker {
        +void generateRandomString(int length)
    }
    AuroCalendarCell --> AuroDatePicker
    AuroCalendarCell --> AuroPopover
    AuroCalendarCell --> AuroLibraryRuntimeUtils
    AuroDatePicker --> AuroCalendarCell
Loading

File-Level Changes

Change Details Files
Implemented theme support and color customization
  • Added new CSS files for color management (color-cell.scss, color-calendar.scss, color.scss, color-month.scss)
  • Created tokens.scss file to define custom properties for theming
  • Updated existing SCSS files to use new color variables
  • Modified JavaScript files to import and use new color stylesheets
src/color-cell.scss
src/color-calendar.scss
src/color.scss
src/color-month.scss
src/tokens.scss
src/style-auro-calendar-cell.scss
src/style-auro-calendar.scss
src/style-auro-calendar-month.scss
src/style.scss
src/auro-calendar-cell.js
src/auro-calendar-month.js
src/auro-datepicker.js
src/auro-calendar.js
Refactored code and updated dependencies
  • Updated import statements and function calls
  • Removed unnecessary comments and whitespace
  • Updated version numbers for dependencies
  • Added eslint.config.mjs file
src/auro-calendar-cell.js
src/auro-calendar-month.js
src/auro-datepicker.js
src/auro-calendar.js
index.js
README.md
eslint.config.mjs
Updated documentation and examples
  • Modified demo/api.md to include new theming information
  • Updated apiExamples/dateSlot.html with new highlight attributes
  • Added theme support section to docs/partials/api.md
demo/api.md
apiExamples/dateSlot.html
docs/partials/api.md
Made minor improvements to functionality
  • Added highlight attribute to some date slots in populateSlotContentExample function
  • Modified handleTap function to check for disabled state before handling click
apiExamples/dynamicSlot.js
src/auro-calendar-cell.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jordanjones243
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

@jordanjones243 jordanjones243 linked an issue Oct 3, 2024 that may be closed by this pull request
2 tasks
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The refactoring of color-related styles into separate files is a good improvement for maintainability. Consider documenting the purpose of each new color file in a comment at the top of the file.
  • The addition of theme support using CSS custom properties is excellent. It might be helpful to provide a brief guide or example in the documentation on how to use these new theming capabilities.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 2 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

demo/api.md Show resolved Hide resolved
demo/api.md Show resolved Hide resolved
Copy link

github-actions bot commented Oct 3, 2024

Surge demo deployment failed! 😭

@jordanjones243 jordanjones243 linked an issue Oct 3, 2024 that may be closed by this pull request
jordanjones243 and others added 2 commits October 4, 2024 12:46
BREAKING CHANGE: trigger major release for color theme support #206
# [3.0.0-beta.1](v2.8.0-beta.2...v3.0.0-beta.1) (2024-10-04)

### Performance Improvements

* **label:** remove github label colors ([7a933f2](7a933f2))

### BREAKING CHANGES

* **label:** trigger major release for color theme support #206
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jason-capsule42 jason-capsule42 merged commit 485a66c into main Oct 4, 2024
8 of 10 checks passed
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color tokens for theming support Design token needed for themeing
5 participants