Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic color token names #14

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Mar 14, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #13

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Update design token version and all other dependencies
  • Refactor color tokens by isolating the color tokens and creating tier 3 tokens for repeatable rules

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

Verification:

  • UI looks the same as it does on docsite
  • Background UI looks correct
  • Tier 3 tokens are named correctly
  • Tier 3 tokens are pointing to correct tier 2 tokens

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jordanjones243 jordanjones243 self-assigned this Mar 14, 2024
@jordanjones243 jordanjones243 linked an issue Mar 14, 2024 that may be closed by this pull request
2 tasks
@jordanjones243 jordanjones243 force-pushed the jjones/updateTokenNames/#13 branch from 793f786 to 2e6d670 Compare June 3, 2024 20:28
@jordanjones243 jordanjones243 marked this pull request as ready for review June 3, 2024 20:36
@jordanjones243 jordanjones243 requested a review from a team as a code owner June 3, 2024 20:36
Copy link
Member

@jason-capsule42 jason-capsule42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component needs to have updates matching drawer

AlaskaAirlines/auro-drawer#15

@jordanjones243 jordanjones243 force-pushed the jjones/updateTokenNames/#13 branch 2 times, most recently from 8cd72d7 to ecf69d3 Compare June 25, 2024 22:21
@jordanjones243 jordanjones243 changed the base branch from main to beta June 25, 2024 22:22
@jordanjones243 jordanjones243 force-pushed the jjones/updateTokenNames/#13 branch 3 times, most recently from da0837e to f9e8635 Compare June 26, 2024 18:28
@jordanjones243 jordanjones243 force-pushed the jjones/updateTokenNames/#13 branch from 0c42d83 to 5cd4ec7 Compare July 3, 2024 20:13
@jordanjones243 jordanjones243 force-pushed the jjones/updateTokenNames/#13 branch from 705465c to d0f05c8 Compare July 3, 2024 21:02
@jason-capsule42 jason-capsule42 force-pushed the jjones/updateTokenNames/#13 branch from d0f05c8 to f7de872 Compare July 3, 2024 23:36
jason-capsule42
jason-capsule42 previously approved these changes Jul 3, 2024
eslint.config.mjs Outdated Show resolved Hide resolved
@jason-capsule42 jason-capsule42 force-pushed the jjones/updateTokenNames/#13 branch from dba9af5 to 4b65528 Compare July 4, 2024 00:13
@jason-capsule42 jason-capsule42 self-requested a review July 4, 2024 00:15
@jason-capsule42 jason-capsule42 merged commit 8de7e7c into beta Jul 4, 2024
4 checks passed
@jason-capsule42 jason-capsule42 deleted the jjones/updateTokenNames/#13 branch July 4, 2024 00:15
@jordanjones243
Copy link
Contributor Author

🎉 This PR is included in version 1.1.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color tokens for theming support
2 participants