Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy es5 bundling resources #44

Closed
blackfalcon opened this issue May 4, 2023 · 1 comment · Fixed by #52
Closed

Remove legacy es5 bundling resources #44

blackfalcon opened this issue May 4, 2023 · 1 comment · Fixed by #52
Assignees
Labels
Status: Work In Progress Issue or Pull Request work is in Progress

Comments

@blackfalcon
Copy link
Member

blackfalcon commented May 4, 2023

Is your feature request related to a problem? Please describe.

This repo still contains resources related to the bundling of an es5 module, local demo Sass, and still supports legacy concepts like non-rem CSS post-processing.

Describe the solution you'd like

Remove all es5 resources required for bundling. This includes all script references and npm dependencies.

Remove these legacy services. Also, make sure that they are removed from all documentation including the README and API docs.

Update the index.html file in the ./dir to use CDN style resources. The local demo Sass resources should be deleted. The npm script for processing these demo styles should also be released

Please delete any _legacy directory if one exists.

Exit criteria

This issue will be complete once all legacy Sass and es5 building resources have been removed from the repo.

See linked commits for update references.

Also, see this added commit that addresses additional updates that may be required

@blackfalcon blackfalcon added auro-flight Status: Work In Progress Issue or Pull Request work is in Progress labels May 4, 2023
@blackfalcon blackfalcon added this to the Node 18+ update milestone May 4, 2023
@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/auro-flight May 4, 2023
@blackfalcon blackfalcon added Type: perf and removed Status: Work In Progress Issue or Pull Request work is in Progress labels May 4, 2023
@blackfalcon
Copy link
Member Author

/duplicate

@fajar-apri-alaska fajar-apri-alaska self-assigned this May 5, 2023
@fajar-apri-alaska fajar-apri-alaska added the Status: Work In Progress Issue or Pull Request work is in Progress label May 5, 2023
fajar-apri-alaska added a commit that referenced this issue May 5, 2023
Changes to be committed:
	modified:   README.md
	deleted:    babel.config.js
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	deleted:    rollup.config.js
	new file:   rollup.config.mjs
	deleted:    src/es5.js
@fajar-apri-alaska fajar-apri-alaska mentioned this issue May 5, 2023
3 tasks
@fajar-apri-alaska fajar-apri-alaska linked a pull request May 5, 2023 that will close this issue
3 tasks
@fajar-apri-alaska fajar-apri-alaska removed a link to a pull request May 5, 2023
3 tasks
@fajar-apri-alaska fajar-apri-alaska linked a pull request May 5, 2023 that will close this issue
3 tasks
@fajar-apri-alaska fajar-apri-alaska removed a link to a pull request May 8, 2023
3 tasks
@fajar-apri-alaska fajar-apri-alaska linked a pull request May 8, 2023 that will close this issue
3 tasks
blackfalcon pushed a commit that referenced this issue Aug 2, 2023
Changes to be committed:
	modified:   README.md
	deleted:    babel.config.js
	modified:   demo/index.html
	modified:   package-lock.json
	modified:   package.json
	deleted:    rollup.config.js
	new file:   rollup.config.mjs
	deleted:    src/es5.js
blackfalcon pushed a commit that referenced this issue Aug 2, 2023
# [2.0.0](v1.4.0...v2.0.0) (2023-08-02)

### Bug Fixes

* **demo:** update demo.md custom component html ([9e40bd4](9e40bd4))
* **postinstall:** renamed postinstall.js ([3a3cfac](3a3cfac))
* **tsc:** update typo filename ([dc1e4d7](dc1e4d7))

### Documentation

* **npm:** Update npm namespace ([464c480](464c480))

### Features

* **cq:** remove custom container query support [#56](#56) ([4ea9bd5](4ea9bd5))
* **customize:** update component registration [#45](#45) ([c1ae11e](c1ae11e))
* **typescript:** add typescript support [#45](#45) ([32d54a0](32d54a0))

### Performance Improvements

* add build:watch command npm script ([439d434](439d434))
* **es5:** Remove legacy es5 bundling resource [#44](#44) ([781a79b](781a79b))
* **husky:** pre-commit and husky update [#45](#45) ([70f1edd](70f1edd))
* **husky:** update config to support linters ([6397945](6397945))
* **lit:** update to Lit2.0 [#45](#45) ([0bb2505](0bb2505))
* **node18:** update to support Node 18++ [#46](#46) ([107791d](107791d))
* **sass:** Update to use dart-sass dependency ([6012dc1](6012dc1))
* **server:** update to use single shell [#53](#53) ([1418d25](1418d25))

### BREAKING CHANGES

* **cq:** This commit removes the custom built
container query support and replaces it with standard
CSS container query support.

This commit also REMOVES the custom `cq` attribute as this
is no longer supported. The default `414px` width was replaced
with the standard `auro-grid-breakpoint-xs` token.

Changes to be committed:
modified:   docs/api.md
modified:   src/auro-flightline.js
deleted:    src/observer.js
modified:   src/style-flightline.scss
modified:   test/auro-flightline.test.js
* **npm:** This update will redefine the npm namespace
for the auro-flightline element.

Changes to be committed:
	modified:   package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Work In Progress Issue or Pull Request work is in Progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants