-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace resize observer with CSS container queries #56
Milestone
Comments
Merged
3 tasks
blackfalcon
added a commit
that referenced
this issue
Aug 2, 2023
BREAKING CHANGE: This commit removes the custom built container query support and replaces it with standard CSS container query support. This commit also REMOVES the custom `cq` attribute as this is no longer supported. The default `414px` width was replaced with the standard `auro-grid-breakpoint-xs` token. Changes to be committed: modified: docs/api.md modified: src/auro-flightline.js deleted: src/observer.js modified: src/style-flightline.scss modified: test/auro-flightline.test.js
blackfalcon
added a commit
that referenced
this issue
Aug 2, 2023
BREAKING CHANGE: This commit removes the custom built container query support and replaces it with standard CSS container query support. This commit also REMOVES the custom `cq` attribute as this is no longer supported. The default `414px` width was replaced with the standard `auro-grid-breakpoint-xs` token. Changes to be committed: modified: docs/api.md modified: src/auro-flightline.js deleted: src/observer.js modified: src/style-flightline.scss modified: test/auro-flightline.test.js
blackfalcon
pushed a commit
that referenced
this issue
Aug 2, 2023
# [2.0.0](v1.4.0...v2.0.0) (2023-08-02) ### Bug Fixes * **demo:** update demo.md custom component html ([9e40bd4](9e40bd4)) * **postinstall:** renamed postinstall.js ([3a3cfac](3a3cfac)) * **tsc:** update typo filename ([dc1e4d7](dc1e4d7)) ### Documentation * **npm:** Update npm namespace ([464c480](464c480)) ### Features * **cq:** remove custom container query support [#56](#56) ([4ea9bd5](4ea9bd5)) * **customize:** update component registration [#45](#45) ([c1ae11e](c1ae11e)) * **typescript:** add typescript support [#45](#45) ([32d54a0](32d54a0)) ### Performance Improvements * add build:watch command npm script ([439d434](439d434)) * **es5:** Remove legacy es5 bundling resource [#44](#44) ([781a79b](781a79b)) * **husky:** pre-commit and husky update [#45](#45) ([70f1edd](70f1edd)) * **husky:** update config to support linters ([6397945](6397945)) * **lit:** update to Lit2.0 [#45](#45) ([0bb2505](0bb2505)) * **node18:** update to support Node 18++ [#46](#46) ([107791d](107791d)) * **sass:** Update to use dart-sass dependency ([6012dc1](6012dc1)) * **server:** update to use single shell [#53](#53) ([1418d25](1418d25)) ### BREAKING CHANGES * **cq:** This commit removes the custom built container query support and replaces it with standard CSS container query support. This commit also REMOVES the custom `cq` attribute as this is no longer supported. The default `414px` width was replaced with the standard `auro-grid-breakpoint-xs` token. Changes to be committed: modified: docs/api.md modified: src/auro-flightline.js deleted: src/observer.js modified: src/style-flightline.scss modified: test/auro-flightline.test.js * **npm:** This update will redefine the npm namespace for the auro-flightline element. Changes to be committed: modified: package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
The following code is part of a bootstrap solution to support container queries before CSS container queries were broadly available.
auro-flightline/src/auro-flightline.js
Lines 26 to 42 in 63ed29d
The current issue is that the following tests are failing for unknown reasons.
auro-flightline/test/auro-flightline.test.js
Lines 57 to 80 in 63ed29d
Describe the solution you'd like
Instead of updating code/tests it is preferred that we remove the bootstrap code and update the component to use CSS container queries that are easily supported by the browser. This solution will remove the maintenance and testing dependency related to supporting the bootstrap solution.
https://caniuse.com/css-container-queries
https://mxb.dev/blog/container-queries-web-components/
This will be a BREAKING CHANGE in regards to the
cq
attribute will no longer be supported. This work should be addressed with the current efforts to re-release the component under the@aurodesignsystem
npm namespace.Describe alternatives you've considered
Trying to fix the code/tests.
Exit criteria
This issue will be considered complete once the resize observer code has been removed from the project and the currently supported feature (see attached screenshot) is still supported without any changes needed by the consumers.
The text was updated successfully, but these errors were encountered: