Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-formkit Ensure all components support correct setCustomValidity variations #155

Closed
jordanjones243 opened this issue Dec 27, 2024 · 1 comment · Fixed by #165
Closed

auro-formkit Ensure all components support correct setCustomValidity variations #155

jordanjones243 opened this issue Dec 27, 2024 · 1 comment · Fixed by #165
Assignees
@jordanjones243
Labels
auro-form Type: Bug Bug or Bug fixes

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Dec 27, 2024 •
edited
Loading

Please verify the version of auro-form you have installed

1.5.0

Please describe the bug

Certain form components are either not documenting or not supporting the correct setCustomValidity variations properly. An example we can see is in select:

  1. Go to https://auro.alaskaair.com/components/auro/select/api
  2. Scroll to see which setCustomValidity states are present
  3. Scroll down to value example
  4. Set the value to invalid option
  5. See error state
  6. See error (there is no setCustomValidityBadInput variation supported)

Reproducing the error

This issue is reproducible on the Auro docsite

Expected behavior

When a component is put into an error state, we should see the correct setCustomValidity variation being used to set the error message.

Exit criteria

All components support the correct setCustomValidity states and all of those states are documented under the attribute section, as well as have examples on the API page.
@jordanjones243 jordanjones243 added auro-form not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Dec 27, 2024
@jordanjones243 jordanjones243 removed the not-reviewed Issue has not been reviewed by Auro team members label Dec 27, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Dec 31, 2024
@jordanjones243 jordanjones243 self-assigned this Jan 2, 2025
@jordanjones243 jordanjones243 linked a pull request Jan 3, 2025 that will close this issue
Update validity state functionality and documentation #165
Merged
jordanjones243 added a commit that referenced this issue Jan 7, 2025
@jordanjones243
feat: update custom validity message logic and docs #155
7c87570
jordanjones243 added a commit that referenced this issue Jan 7, 2025
@jordanjones243
feat: update custom validity message logic and docs #155
009587a
jordanjones243 added a commit that referenced this issue Jan 8, 2025
@jordanjones243
feat: update custom validity message logic and docs #155 #156
e53f6e1 
BREAKING CHANGE: input's errorMessage is now a private property.
jordanjones243 added a commit that referenced this issue Jan 8, 2025
@jordanjones243
feat: update custom validity message logic and docs #155 #156
893d6b9 
BREAKING CHANGE: input's errorMessage is now a private property.
jordanjones243 added a commit that referenced this issue Jan 8, 2025
@jordanjones243
feat: update custom validity message logic and docs #155 #156
dc40380 
BREAKING CHANGE: input's errorMessage is now a private property.
jordanjones243 added a commit that referenced this issue Jan 9, 2025
@jordanjones243
feat: update custom validity message logic and docs #155 #156
beec66a 
BREAKING CHANGE: input's errorMessage is now a private property.
@jordanjones243
Copy link
Contributor Author

Ticket can be closed, as the attached PR was merged into Beta.

jason-capsule42 pushed a commit that referenced this issue Jan 9, 2025
@semantic-release-bot
chore(release): 2.0.0-beta.3 [skip ci]
30b430d 
# [2.0.0-beta.3](v2.0.0-beta.2...v2.0.0-beta.3) (2025-01-09)

### Bug Fixes

* make x icon take no space when invisible [#164](#164) ([7ad63e2](7ad63e2))

### Features

* update custom validity message logic and docs [#155](#155) [#156](#156) ([beec66a](beec66a))

### Performance Improvements

* add animation to clear icon and add shared mixin file ([4c6a1e1](4c6a1e1))
* add optional chaining to validation logic ([c4de243](c4de243))
* update handling of invalid values in select ([d1eb0bf](d1eb0bf))
* update validity to use patternMismatch state [#163](#163) ([4c9f9a4](4c9f9a4))

### BREAKING CHANGES

* input's errorMessage is now a private property.
* patternMismatch replaces badInput state when user inputs do not match the expected pattern.
@jason-capsule42 jason-capsule42 changed the title Ensure all components support correct setCustomValidity variations auro-formkit Ensure all components support correct setCustomValidity variations Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-form Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update validity state functionality and documentation AlaskaAirlines/auro-formkit
2 participants
@jordanjones243 @Patrick-Daly-AA