Update validity state functionality and documentation #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request updates the validity state functionality and documentation for form components. The key change is the replacement of the Class diagram showing updated form validation componentsclassDiagram
class BaseInput {
+String error
+String validity
+String setCustomValidity
+String setCustomValidityCustomError
+String setCustomValidityPatternMismatch
+String setCustomValidityValueMissing
+String setCustomValidityTooShort
+String setCustomValidityTooLong
+String setCustomValidityRangeOverflow
+String setCustomValidityRangeUnderflow
+validate()
}
class AuroInput {
+render()
}
class AuroSelect {
+String error
+String validity
+String setCustomValidity
+String setCustomValidityCustomError
+String setCustomValidityValueMissing
+reset()
+validate()
}
class AuroDatePicker {
+String error
+String validity
+String setCustomValidity
+String setCustomValidityCustomError
+String setCustomValidityValueMissing
+validate()
}
BaseInput <|-- AuroInput
BaseInput <|-- AuroSelect
BaseInput <|-- AuroDatePicker
note for BaseInput "Base class with common validation functionality"
State diagram for form validation statesstateDiagram-v2
[*] --> Valid
Valid --> Invalid: Validation fails
Invalid --> Valid: Validation passes
state Invalid {
[*] --> CustomError: error attribute set
[*] --> ValueMissing: required but empty
[*] --> PatternMismatch: pattern validation fails
[*] --> RangeOverflow: value > max
[*] --> RangeUnderflow: value < min
[*] --> TooLong: value too long
[*] --> TooShort: value too short
}
Invalid --> Valid: Validation passes
Valid --> [*]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
This was
linked to
issues
Jan 3, 2025
jordanjones243
force-pushed
the
jjones/validityStateUpdates
branch
2 times, most recently
from
cd34721 to
e69fb46
Compare
jordanjones243
force-pushed
the
jjones/validityStateUpdates
branch
from
7c87570 to
009587a
Compare
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @jordanjones243 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
jordanjones243
force-pushed
the
jjones/validityStateUpdates
branch
2 times, most recently
from
6ad2251 to
c2c4c56
Compare
BREAKING CHANGE: patternMismatch replaces badInput state when user inputs do not match the expected pattern.
BREAKING CHANGE: input's errorMessage is now a private property.
jordanjones243
force-pushed
the
jjones/validityStateUpdates
branch
from
c2c4c56 to
510ad18
Compare
jason-capsule42
approved these changes
Jan 9, 2025
|
🎉 This PR is included in version 2.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Before Submitting this pull request:
Developmentsectionnote: all pull requests require at least one linked ticket
Ready For Review, all ticket's linked underDevelopmentmust have their status changed toReady For Reviewas wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Update the validity state functionality and documentation for form components.
Summary by Sourcery
Update the handling of validation states and error messages for form components.
New Features:
Enhancements:
Documentation: