Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled version of hyperlink is not working as expected #161

Closed
1 of 2 tasks
blackfalcon opened this issue Feb 27, 2023 · 1 comment · Fixed by #162
Closed
1 of 2 tasks

Bundled version of hyperlink is not working as expected #161

blackfalcon opened this issue Feb 27, 2023 · 1 comment · Fixed by #162
Assignees
Labels

Comments

@blackfalcon
Copy link
Member

Describe the bug

Reviewing the latest release of auro-hypelrink v3.3.1 on the Auro docsite it was discovered that the bundled version is not operating as expected.

Verify the version of @aurodesignsystem/auro-hyperlink you have installed

The current version is:
See it on NPM!

My project has @aurodesignsystem/auro-hyperlink v3.3.1 installed

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://auro.alaskaair.com/components/auro/hyperlink
  2. See error

Are you able to reproduce this issue on the Auro doc site?

  • YES
  • NO

Expected behavior

The hyperlink component should work as expected when using the bundled version.

Screenshots

Screen Shot 2023-02-27 at 9 33 06 AM

Additional context

@blackfalcon blackfalcon added Type: Bug Bug or Bug fixes auro-hyperlink not-reviewed Issue has not been reviewed by Auro team members and removed not-reviewed Issue has not been reviewed by Auro team members labels Feb 27, 2023
@blackfalcon
Copy link
Member Author

Doing some digging it was discovered that the issue here is with our new process of importing the element js into the scope of the index.js file. See this link from Rollup docs

https://rollupjs.org/troubleshooting/#warning-treating-module-as-external-dependency

This issue would have been difficult to realize in any local testing. The error in the CLI is easily missed and even if you were testing the bundled version, the error resulted in NOT creating a new bundled version and the old version is still in the dist directory.

I am advocating for a process update in the build script that will use the sweep command prior to a new build. This will ensure that legacy assets are not left around prior to a new build thus directly exposing new issues.

blackfalcon added a commit that referenced this issue Feb 28, 2023
This commit corrects an issue that needs to
be added with any update to a component that
moves the registration of the element outside
of the element's .js file to the index.js file.

Changes to be committed:
modified:   demo/index.html
modified:   package-lock.json
modified:   package.json
modified:   rollup.config.js
blackfalcon added a commit that referenced this issue Feb 28, 2023
This commit corrects an issue that needs to
be added with any update to a component that
moves the registration of the element outside
of the element's .js file to the index.js file.

Changes to be committed:
modified:   demo/index.html
modified:   package-lock.json
modified:   package.json
modified:   rollup.config.js
blackfalcon added a commit that referenced this issue Feb 28, 2023
This commit corrects an issue that needs to
be added with any update to a component that
moves the registration of the element outside
of the element's .js file to the index.js file.

Changes to be committed:
modified:   demo/index.html
modified:   package-lock.json
modified:   package.json
modified:   rollup.config.js
@jordanjones243 jordanjones243 linked a pull request Feb 28, 2023 that will close this issue
6 tasks
blackfalcon added a commit that referenced this issue Feb 28, 2023
This commit corrects an issue that needs to
be added with any update to a component that
moves the registration of the element outside
of the element's .js file to the index.js file.

Changes to be committed:
modified:   demo/index.html
modified:   package-lock.json
modified:   package.json
modified:   rollup.config.js
jordanjones243 pushed a commit that referenced this issue Feb 28, 2023
This commit corrects an issue that needs to
be added with any update to a component that
moves the registration of the element outside
of the element's .js file to the index.js file.

Changes to be committed:
modified:   demo/index.html
modified:   package-lock.json
modified:   package.json
modified:   rollup.config.js
blackfalcon pushed a commit that referenced this issue Feb 28, 2023
## [3.3.2](v3.3.1...v3.3.2) (2023-02-28)

### Bug Fixes

* **bundle:** update rollup config [#161](#161) ([abe252a](abe252a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants