-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundled version of hyperlink is not working as expected #161
Comments
Doing some digging it was discovered that the issue here is with our new process of importing the element js into the scope of the index.js file. See this link from Rollup docs https://rollupjs.org/troubleshooting/#warning-treating-module-as-external-dependency This issue would have been difficult to realize in any local testing. The error in the CLI is easily missed and even if you were testing the bundled version, the error resulted in NOT creating a new bundled version and the old version is still in the dist directory. I am advocating for a process update in the build script that will use the |
This commit corrects an issue that needs to be added with any update to a component that moves the registration of the element outside of the element's .js file to the index.js file. Changes to be committed: modified: demo/index.html modified: package-lock.json modified: package.json modified: rollup.config.js
This commit corrects an issue that needs to be added with any update to a component that moves the registration of the element outside of the element's .js file to the index.js file. Changes to be committed: modified: demo/index.html modified: package-lock.json modified: package.json modified: rollup.config.js
This commit corrects an issue that needs to be added with any update to a component that moves the registration of the element outside of the element's .js file to the index.js file. Changes to be committed: modified: demo/index.html modified: package-lock.json modified: package.json modified: rollup.config.js
This commit corrects an issue that needs to be added with any update to a component that moves the registration of the element outside of the element's .js file to the index.js file. Changes to be committed: modified: demo/index.html modified: package-lock.json modified: package.json modified: rollup.config.js
This commit corrects an issue that needs to be added with any update to a component that moves the registration of the element outside of the element's .js file to the index.js file. Changes to be committed: modified: demo/index.html modified: package-lock.json modified: package.json modified: rollup.config.js
## [3.3.2](v3.3.1...v3.3.2) (2023-02-28) ### Bug Fixes * **bundle:** update rollup config [#161](#161) ([abe252a](abe252a))
Describe the bug
Reviewing the latest release of auro-hypelrink v3.3.1 on the Auro docsite it was discovered that the bundled version is not operating as expected.
Verify the version of @aurodesignsystem/auro-hyperlink you have installed
The current version is:
My project has @aurodesignsystem/auro-hyperlink
v3.3.1
installedTo Reproduce
Steps to reproduce the behavior:
Are you able to reproduce this issue on the Auro doc site?
Expected behavior
The hyperlink component should work as expected when using the bundled version.
Screenshots
Additional context
The text was updated successfully, but these errors were encountered: