Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rollup config needs to be updated to support new custom element version control work #15

Closed
jordanjones243 opened this issue Feb 28, 2023 · 0 comments · Fixed by #16
Closed

rollup config needs to be updated to support new custom element version control work #15

jordanjones243 opened this issue Feb 28, 2023 · 0 comments · Fixed by #16
Assignees
@jordanjones243
Labels
auro-nav
Milestone
v1.0 auro-nav

Comments

@jordanjones243
Copy link
Contributor

General Support Request

Support request

rollup.config.js needs to be updated to support new custom element version control work to get the bundled version to work as expected.

Possible Solution

Need to use the nodeResolve() function within the plugins of the rollup.config.js file.

Context

This work stems from an issue found from auro-hyperlink:
@jordanjones243 jordanjones243 added auro-nav not-reviewed Issue has not been reviewed by Auro team members labels Feb 28, 2023
@jordanjones243 jordanjones243 self-assigned this Feb 28, 2023
jordanjones243 added a commit that referenced this issue Feb 28, 2023
@jordanjones243
perf(rollup): update rollup config to support CE work #15
cdc9675 
This commit corrects an issue that needs to
be added with any update to a component that
moves the registration of the element outside
of the element's .js file to the index.js file.

Changes to be committed:
modified:   package-lock.json
modified:   package.json
modified:   rollup.config.js
@jordanjones243 jordanjones243 mentioned this issue Feb 28, 2023
Merged
6 tasks
@jordanjones243 jordanjones243 linked a pull request Feb 28, 2023 that will close this issue
Update rollup config and depencencies #16
Merged
6 tasks
@jordanjones243 jordanjones243 added this to the v1.0 auro-nav milestone Feb 28, 2023
@blackfalcon blackfalcon added Type: Perf and removed not-reviewed Issue has not been reviewed by Auro team members labels Feb 28, 2023
jordanjones243 added a commit that referenced this issue Feb 28, 2023
@jordanjones243
perf(rollup): update rollup config to support CE work #15
241317f 
This commit corrects an issue that needs to
be added with any update to a component that
moves the registration of the element outside
of the element's .js file to the index.js file.

Changes to be committed:
modified:   package-lock.json
modified:   package.json
modified:   rollup.config.js
jordanjones243 added a commit that referenced this issue Feb 28, 2023
@jordanjones243
perf(rollup): update rollup config to support CE work #15
d738912 
This commit corrects an issue that needs to
be added with any update to a component that
moves the registration of the element outside
of the element's .js file to the index.js file.

Changes to be committed:
modified:   package-lock.json
modified:   package.json
modified:   rollup.config.js
blackfalcon pushed a commit that referenced this issue Feb 28, 2023
@semantic-release-bot
chore(release): 1.0.1 [skip ci]
2307491 
## [1.0.1](v1.0.0...v1.0.1) (2023-02-28)

### Performance Improvements

* **deps:** update hyperlink dependency [#13](#13) ([28ee825](28ee825))
* **rollup:** update rollup config to support CE work [#15](#15) ([d738912](d738912))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-nav
Projects
None yet
Milestone
v1.0 auro-nav
Development

Successfully merging a pull request may close this issue.

Update rollup config and depencencies AlaskaAirlines/auro-nav
2 participants
@blackfalcon @jordanjones243